[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: 3.0.19 show-stoppers



On Thu, Jan 24, 2002 at 04:21:28PM +0100, Stefan Gybas wrote:
> On Thu, Jan 24, 2002 at 01:36:37PM +0100, Stefan Gybas wrote:
> 
> > I'll make this change in my NMU which fixes the s390 problems.
> 
> Testing with current CVS boot-floppies on s390 shows that this section
> does not work. It causes dbootstrap to hang after calling debootstrap
> (maybe because the cat process isn't properly killed?) and all packages
> have been set up. The last message is "I: debootstrap: Successfully
> completed" from exec_debootstrap() in extract_base.c - the rest is not
> executed:
> 
>     mkfifo $TARGET/dev/initctl
>     cat <$TARGET/dev/initctl >/dev/null &
>     CAT_PID=$!
>     on_exit "kill $CAT_PID >/dev/null 2>&1"
> 
> I'd like to disable this section for the boot-floppies, it's not
> necessary there:
> 
>     if [ -n "$USE_BOOTFLOPPIES_INTERACTION" ]; then
>         mknod -m 600 $TARGET/dev/initctl p
>         cat <$TARGET/dev/initctl >/dev/null &
>         CAT_PID=$!
>         on_exit "kill $CAT_PID >/dev/null 2>&1"
>     fi
> 
> Any objections? Does the old section work on other architectures?

I object.  We should fix, rather than disable, it.  Could you
please try the following code instead?

    mknod $TARGET/dev/initctl
    tail -f <$TARGET/dev/initctl >/dev/null &
    TAIL_PID=$!
    on_exit "kill $TAIL_PID"

Matt

Attachment: pgp_DP7MIPI7W.pgp
Description: PGP signature


Reply to: