[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#123973: allowing "mount -t auto" as fallback



#include <hallo.h>
Adam Di Carlo wrote on Tue Dec 18, 2001 um 01:52:26AM:

> > Hm. Microsoft was very clever and invented different partition types for
> > FAT. Our autodetection routines may fail sometimes. I think we could
> > make a workaround relying on the autodetection of the filesystem. Has
> > anyone a better idea? I think this should work:
> 
> I don't understand what your patch is doing.

Okay, before this patch, we got the fixed filesytem type from libfdisk.
But libfdisk did allways return "msdos" - and the ancient msdos driver
does not support fat32 variant at all.

> Why would we want the -r switch and p->name twice?

Just copy&pasted to feed sprintf with the same arguments. But forget it,
I made another workaround to replace msdos with vfat if supported. This
is untested, but should work. I will test later.

Index: choose_medium.c
===================================================================
RCS file: /cvs/debian-boot/boot-floppies/utilities/dbootstrap/choose_medium.c,v
retrieving revision 1.118
diff -u -r1.118 choose_medium.c
--- choose_medium.c	2001/11/03 15:28:01	1.118
+++ choose_medium.c	2001/12/18 08:50:33
@@ -929,6 +929,11 @@
 		     fdisk_sysname(p->type));
 	return 1;
     }
+    
+    /* if libfdisk reported msdos but we have vfat support, use vfat */
+    if(strcmp(type,"msdos")==0 && !is_filesystem_supported("vfat"))
+       type="vfat";
+    
 #ifndef _TESTING_
     snprintf(prtbuf, sizeof(prtbuf),
 	     "mount -t %s %s %s " CM_MOUNTPOINT_DIR, 

Gruss/Regards,
Eduard.
-- 
Everything should be made as simple as possible, but not simpler.
                -- Albert Einstein

Attachment: pgpZUcfF9H5yM.pgp
Description: PGP signature


Reply to: