Interesting for mke2fs on boot floppies [Bug#108165]

[Eduard Bloch <edi@gmx.de>]

BFs should use a fixed version when it is ready.

----- Forwarded message from Eduard Bloch <blade@debian.org> -----

Date: Thu, 09 Aug 2001 17:28:14 +0200
From: Eduard Bloch <blade@debian.org>
Subject: e2fsck ignores "-O none" and creates e2fs without 2.0.x-compatibility
To: Debian Bug Tracking System <submit@bugs.debian.org>
X-Mailer: reportbug 1.23

Package: e2fsprogs
Version: 1.22-2
Severity: important
Tags: sid patch

Hello, I want to create a file system for an 2.0.x kernel. According to the
manpage, 2.0 didn't support any special features, so I use "-O none" as
described. Unfortunately, the created filesystem has an special feature though,
the sparse_option. This is easy to fix, I attached a patch. As far as I can
see, the author uses sparse_option by default, and made the "-r 0" option
disable it, but forgot the same for -O none.

---
/sbin/mke2fs -O none e3fs 
mke2fs 1.22, 22-Jun-2001 for EXT2 FS 0.5b, 95/08/09
...
Writing inode tables: done                            
Writing superblocks and filesystem accounting information: done
...
/sbin/dumpe2fs e3fs  | grep feature
dumpe2fs 1.22, 22-Jun-2001 for EXT2 FS 0.5b, 95/08/09
Filesystem features:      sparse_super
---

--- e2fsprogs-1.22.orig/misc/mke2fs.c
+++ e2fsprogs-1.22/misc/mke2fs.c
@@ -972,8 +972,10 @@
 		parse_raid_opts(raid_opts);
 
 	/* Parse the user-supplied feature_set, if any. */
-	if (feature_set && !strncasecmp(feature_set, "none", 4))
+	if (feature_set && !strncasecmp(feature_set, "none", 4)) {
+      sparse_option = 0;
 		feature_set = NULL;
+   }
 	if (feature_set && e2p_edit_feature(feature_set,
 					    &param.s_feature_compat,
 					    ok_features)) {

-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux zombie 2.4.7-ext3 #47 Thu Aug 9 14:43:42 CEST 2001 i686
Locale: LANG=de_DE, LC_CTYPE=de_DE

Versions of packages e2fsprogs depends on:
ii  libc6                         2.2.3-9    GNU C Library: Shared libraries an





----- End forwarded message -----

-- 
Du musst einen Plan haben. Denn wenn Du keinen Plan hast,
wirst Du zum Teil des Planes eines anderen ...