[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [patch;debian-installer/anna] OBO in malloc computation, whitespace, typedef



*  (Karl M. Hegbloom)

[Yes, I know, old mail]

| 	* retriever.c: 	Whitespace fixups - space around operators please.

Why?  It's ugly and if Joey Hess didn't intend to have space around
the operators, it shouldn't be added.

| 	Cast of void * returned by malloc unrequired in ANSI C.

So, does no harm?

|         Checked the constants to ensure they match string lengths.

They did already.

|         (get_package): Fix OBO in malloc size computation for command buffer

hmm?

| 	* packages.h: typedef package_t

Why?

Except for syntactic sugar, you have provided no patches.

-- 
Tollef Fog Heen
Unix _IS_ user friendly... It's just selective about who its friends are.



Reply to: