[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: mount_partition() and filesystem types



On Thu, Oct 18, 2001 at 10:43:10AM +1300, Mark van Walraven wrote:
> On Tue, Oct 16, 2001 at 11:57:31PM -0800, Ethan Benson wrote:
> > until the kernel adds another nodev filesystem type and your mount
> > starts happily mounting it instead of a real filesystem.
> 
> libfdisk only recognises "partitions" that occur in /proc/partitions.
> Further, mount_partition() filters the remnant by partion type.
> Consequently, no nodev filesystems should be offered for mounting.

thank you for completly missing the point.

i am not talking about libfdisk, i am talking about busybox.

its mount -t auto design is fundementally flawed, it gets a complete
list of kernel supported filesystems via sysfs() then it has a static,
hard coded list of `blacklisted' filesystems it shouldn't try, these
include most of the currently known nodev filesystems, however as soon
as the kernel adds a new nodev filesystem type busybox won't know
about it and it will be the first one it tries on -t auto, resulting
in all your partitions being mounted as foofakefs (because nodev
filesystems never fail to mount, even if you hand them a real device,
they just ignore that).

for reference this is exactly what happened with usbdevfs.

but as i have stated, even if you fix busybox to be smarter you still
have a giant stack of wildcards in all these random filesystems in the
kernel, are they going to behave sanly when told to mount a partition
not containing thier fstype?  or will they fuckup and kill the kernel? 

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgpfNCz4odSuX.pgp
Description: PGP signature


Reply to: