[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#110258: postinst writes infos directly to /dev/tty



On Wed, Aug 29, 2001 at 11:12:51PM +0200, Eduard Bloch wrote:

> That is a good question. I looked at how debootstrap works, and IMHO it
> is complicated. The postinst script is invoked from dpkg, and dpkg is
> running in an chroot environment. I will send a Cc' to d-boot ml, maybe
> someone has an idea.

correct, package installation is done in chroot /target

> > Should this go in the main package or are you suggesting changes for a 
> > version specifically for the install?
> 
> That is an simple changes, so it could go into main, IMHO:
> 
> if [ -f /sbin/dbootstrap ] ; then

this is totally broken and will never work.  there is no
/target/sbin/dbootstrap which is what your going to be testing for in
reality. 

>   # INVENT A BETTER CHECK!

checking for $Noninteractive would work.

>   TTYOUT="| /usr/bin/logger -t lilo-setup"
> else
>   TTYOUT="> /dev/tty"
> fi

why do you even need any of this crap anyway?  just echo to stdout,
debootstrap will redirect that to tty4, and in normal installs users
will see it on thier tty.

> if [ ! -e /boot/boot.b ]; then
>   echo "Making /boot/boot.b a sym-link to boot-menu.b ." $TTYOUT
>   echo "Change the sym-link if you want boot-text.b or boot-compat.b ." $TTYOUT
>   echo
>   ln -s /boot/boot-menu.b /boot/boot.b
> fi

frankly i fail to see the point of even mentioning this in the
postinst anyway.  lilo does have a manual doesn't it? thats the
proper place for this.  or README.Debian.

> echo "Running /usr/sbin/liloconfig" $TTYOUT
> echo 
> /usr/sbin/liloconfig < /dev/tty $TTYOUT

this will be quite harmful on boot-floppies since there is no user
interaction.  Make System Bootable will take care of the steps
normally done by liloconfig.

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgpJRadaEiQyr.pgp
Description: PGP signature


Reply to: