[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#98439: fixed in cvs



Matt Kraai <kraai@debian.org> writes:

> There is already code in rootdisk.sh to place the af_packet.o
> module on the root floppy, and code in /etc/init.d/rcS to insert
> the module.  It isn't included on the root floppy because the
> module is extracted from modules.tgz, but the dependencies don't
> ensure that this file is built before the root floppy.  I updated
> the dependencies, which should fix this problem.

*smooch*

Well, my changes to rootdisk.sh will at least cause the damn thing to
fail if the modules*.tgz file isn't there.

Please add your changelog (I added one for you already, the libfdisk
thing).

The culprit here, according to cvs annotate, anyhow, was Phil Blundell
<pb@debian.org>, who wrote the include_module routine to ignore
failure.  Bad idea!

Lesson: fail on failure please, do not roll merrily along!

-- 
.....Adam Di Carlo....adam@onshore.com.....<URL:http://www.onshored.com/>




Reply to: