[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#88413: marked as done ([PATCH]: modconf broken with ash)



Your message dated Sun, 04 Mar 2001 15:04:16 -0500
with message-id <E14Zejo-0007xH-00@auric.debian.org>
and subject line Bug#88413: fixed in modconf 0.2.32
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Darren Benham
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 4 Mar 2001 03:03:06 +0000
>From davidw@gordian.com Sat Mar 03 21:03:06 2001
Return-path: <davidw@gordian.com>
Received: from gordius.gordian.com [::ffff:192.73.220.81] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 14ZOna-00060J-00; Sat, 03 Mar 2001 21:03:06 -0600
X-bait: aablmeh@gordian.com,mmblmeh@gordian.com,zzblmeh@gordian.com
Received: from ogun.gordian.com (ogun.gordian.com [192.73.220.36])
	by gordius.gordian.com (8.9.3/8.9.3) with ESMTP id TAA03523
	for <submit@bugs.debian.org>; Sat, 3 Mar 2001 19:03:03 -0800 (PST)
Received: (from davidw@localhost)
	by ogun.gordian.com (8.9.3/8.9.3) id TAA82929
	for submit@bugs.debian.org; Sat, 3 Mar 2001 19:03:02 -0800 (PST)
	(envelope-from davidw)
Date: Sat, 3 Mar 2001 19:03:02 -0800
From: David Whedon <dwhedon@gordian.com>
To: submit@bugs.debian.org
Subject: [PATCH]: modconf broken with ash
Message-ID: <[🔎] 20010303190302.B81733@ogun.gordian.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
Delivered-To: submit@bugs.debian.org

Package: modconf
Version: 0.2.31
Severity: grave

ash is used in boot-floppies.  This bug is marked grave because is breaks
boot-floppies.  modconf works fine with bash.

$ /bin/ash < modconf
Syntax error: Bad substitution
$

Now I'll use ash directly and it will give a better error message:
$ diff -u modconf.orig modconf
--- modconf.orig        Sat Mar  3 18:47:37 2001
+++ modconf     Sat Mar  3 18:47:44 2001
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/ash
 # Please make sure this file can be executed by both "bash" and "ash".
 # Also, the external functions used has to be restricted to the ones available
 #   via busybox if it is to be used on the boot floppies
$ ./modconf
./modconf: 115: Syntax error: Bad substitution
$ 


Here is a patch that fixes it.  My guess is that even though the BASH_VERSION
is not defined ash still needs to parse the offending line 115. It fails.

--- modconf.orig	Sat Mar  3 18:47:37 2001
+++ modconf	Sat Mar  3 18:50:26 2001
@@ -109,11 +109,7 @@
 
     local help=""
     local summary=""
-    if [ -z "$BASH_VERSION" ]; then
-      tdir=`echo $directory | tr / _`
-    else
-      tdir=${directory//\//_}
-    fi
+    tdir=`echo $directory | tr / _`
 
     eval "summary=$`echo dir_descr_$tdir`"
 




-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux ruff 2.2.17 #2 Sat Dec 30 11:46:38 PST 2000 i686

Versions of packages modconf depends on:
ii  modutils                      2.4.2-1    Linux module utilities.           
ii  whiptail                      0.50.17-1  Displays user-friendly dialog boxe

---------------------------------------
Received: (at 88413-close) by bugs.debian.org; 4 Mar 2001 20:08:40 +0000
>From troup@auric.debian.org Sun Mar 04 14:08:39 2001
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [::ffff:206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 14Zeo3-0000K5-00; Sun, 04 Mar 2001 14:08:39 -0600
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
	id 14Zejo-0007xH-00; Sun, 04 Mar 2001 15:04:16 -0500
From: Boot Floppies team <debian-boot@lists.debian.org>
To: 88413-close@bugs.debian.org
Subject: Bug#88413: fixed in modconf 0.2.32
Message-Id: <E14Zejo-0007xH-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Sun, 04 Mar 2001 15:04:16 -0500
Delivered-To: 88413-close@bugs.debian.org

We believe that the bug you reported is fixed in the latest version of
modconf, which has been installed in the Debian FTP archive:

modconf_0.2.32_all.deb
  to pool/main/m/modconf/modconf_0.2.32_all.deb
modconf_0.2.32.dsc
  to pool/main/m/modconf/modconf_0.2.32.dsc
modconf_0.2.32.tar.gz
  to pool/main/m/modconf/modconf_0.2.32.tar.gz
A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 88413@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boot Floppies team <debian-boot@lists.debian.org> (supplier of updated modconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat,  3 Mar 2001 19:27:12 -0800
Source: modconf
Binary: modconf
Architecture: source all
Version: 0.2.32
Distribution: unstable
Urgency: low
Maintainer: Boot Floppies team <debian-boot@lists.debian.org>
Changed-By: David Whedon <dwhedon@debian.org>
Description: 
 modconf    - Device Driver Configuration
Closes: 88413
Changes: 
 modconf (0.2.32) unstable; urgency=low
 .
   * fix so will work with /bin/ash. (closes: Bug#88413)
Files: 
 2946379ec016a572a42552fbe22937b5 516 base optional modconf_0.2.32.dsc
 ca45f264a1e074d43f96afbe6ccd5bee 101527 base optional modconf_0.2.32.tar.gz
 726a77d37591c5cd103143674893a3c8 191734 base optional modconf_0.2.32_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE6obbMST1m+6jv1gMRApikAJ4j+tYnnbaPh06uUDHwmCh53RbdFACgh8E4
X8ubGNsmas2PIzzij+8OY7o=
=4K2z
-----END PGP SIGNATURE-----



Reply to: