Bug#63804: marked as done (Cannot select module when two modules have prefix >= 15 chars.)
Your message dated Thu, 22 Feb 2001 15:07:40 -0500
with message-id <E14W21c-00013T-00@auric.debian.org>
and subject line Bug#63804: fixed in modconf 0.2.31
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 9 May 2000 06:27:09 +0000
>From muirp@ieels.com Tue May 09 01:27:09 2000
Received: from h-207-148-141-180.dial.cadvision.com (peter.peter-muir-services.ab.ca) [207.148.141.180] (root)
by master.debian.org with esmtp (Exim 3.12 #2 (Debian))
id 12p3U3-00037G-00; Tue, 09 May 2000 01:27:08 -0500
Received: (from muirp@localhost)
by peter.peter-muir-services.ab.ca (8.9.3/8.9.3/Debian 8.9.3-6) id AAA02940;
Tue, 9 May 2000 00:27:13 -0600
From: Peter Muir <muirp@ieels.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <14615.44957.202958.152929@peter.peter-muir-services.ab.ca>
Date: Tue, 9 May 2000 00:26:37 -0600 (MDT)
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Cannot select module when two modules have prefix >= 15 chars.
X-Mailer: VM 6.72 under 21.1 (patch 8) "Bryce Canyon" XEmacs Lucid
Package: modconf
Version: 0.2.26.14
Severity: wishlist
Linux peter 2.2.14 #1 SMP Mon May 8 09:49:28 MDT 2000 i586 unknown
I installed alsa-driver. There are two drivers in there that have very
long identical prefixes (17 characters):
bash-2.04$ ls /lib/modules/2.2.14/sound/snd-card-opt*
/lib/modules/2.2.14/sound/snd-card-opti92x-ad1848.o
/lib/modules/2.2.14/sound/snd-card-opti92x-cs4231.o
/lib/modules/2.2.14/sound/snd-card-opti93x.o
bash-2.04$
When using modconf and whiptail, I found out whiptail creates
two columns from the tag and titles of all the menu options. It makes
the first column equal to the longest of the tags.
There must be a space at the beginning of the title (or whiptail does
not work). However one can see that if two menu items have the same
prefix then the tag will allow both names (by glob) to be passed to
the modprobe.
I have no solution of course. I thought you might use the first column
for tag and title and the second column only for + or -. Then you
would have to snip off the comment from the tag returned by
whiptail. Or else whiptail might be improved.
Ciao, Peter Muir
Attached: My patch simply removes the truncation of the tag. I also
shorten one of the messages because it gets chopped off.
cd /home/muirp/debian/
cvs rdiff -r debian_version_0_2_26_14 -r debian_version_0_2_26_14_1 debian/modconf
cvs rdiff: Diffing debian/modconf
cvs rdiff: Diffing debian/modconf/debian
Index: debian/modconf/debian/changelog
diff -c debian/modconf/debian/changelog:1.1.1.1 debian/modconf/debian/changelog:1.2
*** debian/modconf/debian/changelog:1.1.1.1 Sun Apr 23 13:33:01 2000
--- debian/modconf/debian/changelog Tue May 9 00:11:07 2000
***************
*** 1,3 ****
--- 1,9 ----
+ modconf (0.2.26.14.1) unstable; urgency=low
+
+ * Because of long module names, do not truncate.
+
+ -- Peter Muir <muirp@ieels.com> Mon, 8 May 2000 13:04:45 -0600
+
modconf (0.2.26.14) frozen unstable; urgency=low
* Thanks to Dan Jacobowitz <dan@debian.org> for pointing out a serious
cvs rdiff: Diffing debian/modconf/modules
Index: debian/modconf/modules/util
diff -c debian/modconf/modules/util:1.1.1.1 debian/modconf/modules/util:1.2
*** debian/modconf/modules/util:1.1.1.1 Sun Apr 23 14:12:21 2000
--- debian/modconf/modules/util Tue May 9 00:13:27 2000
***************
*** 139,145 ****
fi
echo -n \"
! echo -n $module |$sed -e 's/^\(...............\).*$/\1/'
echo -n \" \"$selected" "
module_summary $module
echo \" \\
--- 139,145 ----
fi
echo -n \"
! echo -n $module
echo -n \" \"$selected" "
module_summary $module
echo \" \\
cvs rdiff: Diffing debian/modconf/template
Index: debian/modconf/template/eval_C.fixed
diff -c debian/modconf/template/eval_C.fixed:1.1.1.1 debian/modconf/template/eval_C.fixed:1.2
*** debian/modconf/template/eval_C.fixed:1.1.1.1 Sat Jan 29 14:21:55 2000
--- debian/modconf/template/eval_C.fixed Tue May 9 00:13:43 2000
***************
*** 1,5 ****
# Descriptions must nor exceed a line!
! # Descriptions must not exeed 55 characters!
# substitute `+', `-' and `,' in module names with `_'
msg_Something_went_wrong="Something went wrong. You might want to write down the error messages
--- 1,5 ----
# Descriptions must nor exceed a line!
! # Descriptions must not exeed 50 characters!
# substitute `+', `-' and `,' in module names with `_'
msg_Something_went_wrong="Something went wrong. You might want to write down the error messages
***************
*** 7,13 ****
msg_Cant_make_temfile="Can't make temporary file for dialog box."
msg_Desc_not_avail="(No description available)"
msg_Exit="Exit"
! msg_Finished_these="Finished with these modules. Return to previous menu."
msg_Please_wait_l="Please wait while modules are detected."
msg_Please_wait="Please wait"
msg_module_not_installed="The \$module module is not currently installed."
--- 7,13 ----
msg_Cant_make_temfile="Can't make temporary file for dialog box."
msg_Desc_not_avail="(No description available)"
msg_Exit="Exit"
! msg_Finished_these="Finished here. Return to previous menu."
msg_Please_wait_l="Please wait while modules are detected."
msg_Please_wait="Please wait"
msg_module_not_installed="The \$module module is not currently installed."
Compilation finished at Tue May 9 00:15:57
---------------------------------------
Received: (at 63804-close) by bugs.debian.org; 22 Feb 2001 20:08:10 +0000
>From troup@auric.debian.org Thu Feb 22 14:08:10 2001
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [::ffff:206.246.226.45]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14W225-0001Uz-00; Thu, 22 Feb 2001 14:08:09 -0600
Received: from troup by auric.debian.org with local (Exim 3.12 1 (Debian))
id 14W21c-00013T-00; Thu, 22 Feb 2001 15:07:40 -0500
From: Boot Floppies team <debian-boot@lists.debian.org>
To: 63804-close@bugs.debian.org
Subject: Bug#63804: fixed in modconf 0.2.31
Message-Id: <E14W21c-00013T-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Thu, 22 Feb 2001 15:07:40 -0500
Delivered-To: 63804-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
modconf, which has been installed in the Debian FTP archive:
modconf_0.2.31_all.deb
to pool/main/m/modconf/modconf_0.2.31_all.deb
modconf_0.2.31.dsc
to pool/main/m/modconf/modconf_0.2.31.dsc
modconf_0.2.31.tar.gz
to pool/main/m/modconf/modconf_0.2.31.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 63804@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Boot Floppies team <debian-boot@lists.debian.org> (supplier of updated modconf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 22 Feb 2001 15:21:51 +0100
Source: modconf
Binary: modconf
Architecture: source all
Version: 0.2.31
Distribution: unstable
Urgency: medium
Maintainer: Boot Floppies team <debian-boot@lists.debian.org>
Changed-By: Martin Schulze <joey@finlandia.infodrom.north.de>
Description:
modconf - Device Driver Configuration
Closes: 63804 71875 78924
Changes:
modconf (0.2.31) unstable; urgency=medium
.
* Rewrote some module finding and naming code so modconf will work with
Linux 2.4.x as well. (closes: Bug#78924)
* Added support for LC_MESSAGES in addition to LANG (closes: Bug#71875)
* Applied patch from Peter Muir <muirp@ieels.com> to not truncate long
modules names (caused problems with similar prefixes, like with alsa)
(closes: Bug#63804)
* Updated German translation (Joey)
* Updated Croatian translation (Josip Rodin)
* Updated French translation (Roland Mas)
* Updated Japanese translation (Junichi Uekawa)
* Updated Italian translation (Marco d'Itri, Eugenia Franzoni)
* Updated Swedish translation (Mattias Wadenstein)
Files:
e12065358b8e89f826a8e28755a851fd 516 base optional modconf_0.2.31.dsc
f11cce10dff2175d9bd761f3f26d9744 101500 base optional modconf_0.2.31.tar.gz
c83ce5b25e10d94bf8c95ddd8b819abe 243386 base optional modconf_0.2.31_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE6lSKBW5ql+IAeqTIRAuJMAJ9x8v5FVSGfrIaPtgXdw8+s3WgZTgCeLLWK
veSzxGCAR+dpBhe0L+Ch7rA=
=DX/F
-----END PGP SIGNATURE-----
Reply to: