Re: [patch] Re: [patch] dbootstrap/http-fetch

[Mark van Walraven <markv@wave.co.nz>]

On Tue, Apr 11, 2000 at 12:22:34PM +0200, Marcel Harkema wrote:
> >   Don't worry, not blindly (parameter ordering).

Smart move ;-)

It worked for me in my test build of yesterday (with correct ordering).

>   Added, incl. server_port.

Thanks.

Incidentally, I think the error message on gethostbyname() failure should
not include the port number, as it has nothing to do with resolving
the host name.  It confused my tester into thinking that dbootstrap had
attempted to resolve <host>:<port>.

@@ -218,8 +218,8 @@
   hst = gethostbyname(con_host);
   if (hst == NULL) {
     snprintf(sbuf, sizeof sbuf - 1,
-             "nf_http_fetchfile :: %s:%d couldn't be resolved, %s (errno=%d).\n",
-             con_host, con_port, hstrerror(h_errno), h_errno);
+             "nf_http_fetchfile :: %s couldn't be resolved, %s (errno=%d).\n",
+             con_host, hstrerror(h_errno), h_errno);
     close(sock);
     problemBox(sbuf, _("Problem"));
     return -1;

Comments?

Regards,

Mark.