Re: [PATCH] Makefile globbing problems in 'make check'
Mark van Walraven <markv@wave.co.nz>:
> However, in the check_kernel target there are actions like:
>
> @[ -f "$(kerneli386_compact)" ] || \
> ( echo compact kernel is not available ; exit 1 )
>
> If the glob didn't match any files, the variable will be "". Of course,
> [ -f "" ] always succeeds, thus 'make check' fails positive.
Why does [ -f "" ] succeed for you? It doesn't succeed for me.
> < @[ -f "$(pcmcia_package)" ] || \
> ---
> > @[ -n "$(pcmcia_package)" -a -f "$(pcmcia_package)" ] || \
It would be nicer not to write everything twice like that ...
Edmund
Reply to: