[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: FWD: Bug#54250: tasksel: UI consistency with whiptail/dialog (long)



Joey Hess wrote:
> > * Whiptail uses square brackets to indicate a multiselect list. Ie, 
> >   "[ ] foo" and "[ ] foo". Since it uses "( )" for radio buttons, tasksel's
> >   use of them for multiselct is confusing.

Done.

> > * Whiptail puts a highlight right in the middle of the brackets. This
> >   naturally leads the eye to them, and indicates that you are going to
> >   effect that part of the display. (I personally think that whiptail should
> >   then reposition the cursor to be on top of the highlight it just printed,
> >   but it doesn't do that.. You might want to consider doing so. OTOH, I
> >   personally like the say dialog handles the whole thing better, with the
> >   highlight bar..)

Done.

> > * Whiptail and dialog let you put a prompt in the box with the list. I
> >   suggest you move the "Select the task package(s) appropriate for your
> >   system:" line down and inside the box to comply.

Done.

> > * Whiptail and dialog left justify the screen title, while tasksel centers it.

Done.

> > * If you run "whiptail --title foo --checklist foo 10 30 2 foo '' '' baz ''
> >   '' bar '' '' --backtitle foo", you can see how it handles scrolling. A
> >   scroll bar for tasksel would be a great enhancement, though a bit more
> >   ambitious than the rest of the changes I am requesting. (And who am I to
> >   talk, I still haven't bothered to put one in pdmenu.. :-) Dialog's appoach is
> >   much simpler, BTW, just little indicators top and bottom if there is more
> >   up/down there.
> > * I think you'd do well to kill the line at the bottom of the screen and
> >   turn most of what's there into buttons. "<Task Info> <Exit> <Help>". This
> >   would leave it up to the user to discover enter/space toggles a selection
> >   and tab cycles to the buttons, but that's pretty idiomatic anyway.

Not yet done.

> > * The OK buttons in the help page and task info screen would be more in line
> >   with whiptail if they were blue, and were "<OK>".

Done.

> > * If you run "whiptail --checklist foo 10 42 3 foo 'The foo package rocks'
> >   '' baz 'Another awesome package!' '' bar 'something' '' --title foo", you
> >   can see how it handles tags followed by descriptive text. I think tasksel
> >   is calling out for the same thing, there needs to be a fixed size separator
> >   between the task name and the short description.

Done.

-- 
see shy jo


Reply to: