Bug#29191: marked as done (busybox "star" command incompatible with cpio)
Your message dated Mon, 21 Dec 1998 14:52:47 +0000
with message-id <E0zs6hT-0000rH-00@molec3.dfis.ull.es>
and subject line Fixed in boot-floppies_2.1.3
has caused the attached bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Ian Jackson
(administrator, Debian bugs database)
Received: (at submit) by bugs.debian.org; 9 Nov 1998 04:22:11 +0000
Received: (qmail 27312 invoked from network); 9 Nov 1998 04:22:09 -0000
Received: from cr5112-a.ktchnr1.on.wave.home.com (HELO insight.worldvisions.ca) (24.112.107.106)
by master.debian.org with SMTP; 9 Nov 1998 04:22:09 -0000
Received: from apenwarr by insight.worldvisions.ca with local (Exim 2.04 #1 (Debian))
id 0zcion-0005at-00; Sun, 8 Nov 1998 23:20:45 -0500
Date: Sun, 8 Nov 1998 23:20:45 -0500
From: Avery Pennarun <apenwarr@worldvisions.ca>
To: submit@bugs.debian.org
Subject: busybox "star" command incompatible with cpio
Message-ID: <19981108232045.A21495@worldvisions.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.94.15i
Package: boot-floppies
Version: 2.0.11
Hi,
The busybox "star" command does not seem to be compatible with tar files
created by GNU cpio 2.4.2-21. Directories that cpio includes in the archive
do _not_ end in a trailing slash character, and busybox assumes that they
will, so we end up with directory names truncated by one character.
I'm not sure whether cpio is violating standard tar format or not. The
following patch should correct the problem for busybox, anyway.
Have fun,
Avery
diff -u -r1.1.1.2 tarfn.c
--- busybox/tarfn.c 1998/11/09 03:50:34 1.1.1.2
+++ busybox/tarfn.c 1998/11/09 04:13:47
@@ -136,7 +136,8 @@
}
/* Else, Fall Through */
case Directory:
- h.Name[nameLength - 1] = '\0';
+ if (h.Name[nameLength - 1] == '/')
+ h.Name[nameLength - 1] = '\0';
status = (*functions->MakeDirectory)(&h);
break;
case HardLink:
Reply to: