Bug#203135: marked as done (kbd-chooser: [PATCH] small error and can't handle other file than console-keymaps-*)
Your message dated Mon, 28 Jul 2003 07:17:29 -0400
with message-id <E19h60P-0005mp-00@auric.debian.org>
and subject line Bug#203135: fixed in kbd-chooser 0.24
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Jul 2003 22:23:48 +0000
>From diablero@poindessous.com Sun Jul 27 17:23:45 2003
Return-path: <diablero@poindessous.com>
Received: from smtp5.wanadoo.fr (mwinf0402.wanadoo.fr) [193.252.22.27]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19gtvd-0000uD-00; Sun, 27 Jul 2003 17:23:45 -0500
Received: from thomas (AMontsouris-108-1-3-215.w193-251.abo.wanadoo.fr [193.251.39.215])
by mwinf0402.wanadoo.fr (SMTP Server) with ESMTP id 2A8498000E1
for <submit@bugs.debian.org>; Mon, 28 Jul 2003 00:23:44 +0200 (CEST)
Received: by thomas (Postfix, from userid 1000)
id AA3B613F0D; Mon, 28 Jul 2003 00:23:43 +0200 (CEST)
Date: Mon, 28 Jul 2003 00:23:43 +0200
From: Thomas Poindessous <thomas@poindessous.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: kbd-chooser: [PATCH] small error and can't handle other file than console-keymaps-*
Message-ID: <[🔎] 20030727222343.GA27342@poindessous.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
X-Reportbug-Version: 2.20
User-Agent: Mutt/1.5.4i
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-14.3 required=4.0
tests=BAYES_01,HAS_PACKAGE,PATCH_UNIFIED_DIFF,USER_AGENT_MUTT
autolearn=ham version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20 (1.174.2.15-2003-03-30-exp)
--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: kbd-chooser
Version: 0.23 (not installed)
Severity: normal
Tags: patch
Hi,
here are 2 patchs. The first one corrects a small error. The second one
makes kbd-chooser handling only console-keymaps-* files. In
maplist_parse_file:374, there is a strlen("console-keymaps-").
thanks for your work.
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux thomas 2.4.21-3-k7 #1 Sun Jul 20 19:23:36 EST 2003 i686
Locale: LANG=C, LC_CTYPE=C
--
Thomas Poindessous
--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="kbd-chooser_1.diff"
Index: kbd-chooser.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/tools/kbd-chooser/kbd-chooser.c,v
retrieving revision 1.27
diff -u -r1.27 kbd-chooser.c
--- kbd-chooser.c 15 Jul 2003 08:29:40 -0000 1.27
+++ kbd-chooser.c 27 Jul 2003 22:16:48 -0000
@@ -446,7 +446,7 @@
if (strncmp (ent->d_name, "console-keymaps-", 16) == 0)
strcpy (p, ent->d_name);
else
- strncpy (p, ent->d_name, strchr (ent->d_name, '.') - p);
+ strncpy (p, ent->d_name, strchr (ent->d_name, '.') - ent->d_name);
maplist_select (maplist_parse_file (fullname));
}
}
--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="kbd-chooser_2.diff"
Index: kbd-chooser.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/tools/kbd-chooser/kbd-chooser.c,v
retrieving revision 1.27
diff -u -r1.27 kbd-chooser.c
--- kbd-chooser.c 15 Jul 2003 08:29:40 -0000 1.27
+++ kbd-chooser.c 27 Jul 2003 22:17:39 -0000
@@ -443,11 +443,10 @@
/* two types of name allowed (for the moment; )
* legacy 'console-keymaps-* names and *.keymaps names
*/
- if (strncmp (ent->d_name, "console-keymaps-", 16) == 0)
+ if (strncmp (ent->d_name, "console-keymaps-", 16) == 0) {
strcpy (p, ent->d_name);
- else
- strncpy (p, ent->d_name, strchr (ent->d_name, '.') - p);
- maplist_select (maplist_parse_file (fullname));
+ maplist_select (maplist_parse_file (fullname));
+ }
}
}
--BXVAT5kNtrzKuDFl--
---------------------------------------
Received: (at 203135-close) by bugs.debian.org; 28 Jul 2003 11:23:54 +0000
>From katie@auric.debian.org Mon Jul 28 06:23:54 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19h66c-00066u-00; Mon, 28 Jul 2003 06:23:54 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 19h60P-0005mp-00; Mon, 28 Jul 2003 07:17:29 -0400
From: Alastair McKinstry <mckinstry@debian.org>
To: 203135-close@bugs.debian.org
X-Katie: $Revision: 1.34 $
Subject: Bug#203135: fixed in kbd-chooser 0.24
Message-Id: <E19h60P-0005mp-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Mon, 28 Jul 2003 07:17:29 -0400
Delivered-To: 203135-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
kbd-chooser, which is due to be installed in the Debian FTP archive:
kbd-chooser_0.24.dsc
to pool/main/k/kbd-chooser/kbd-chooser_0.24.dsc
kbd-chooser_0.24.tar.gz
to pool/main/k/kbd-chooser/kbd-chooser_0.24.tar.gz
kbd-chooser_0.24_i386.udeb
to pool/main/k/kbd-chooser/kbd-chooser_0.24_i386.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 203135@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alastair McKinstry <mckinstry@debian.org> (supplier of updated kbd-chooser package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 20 Jul 2003 10:29:49 +0100
Source: kbd-chooser
Binary: kbd-chooser
Architecture: source i386
Version: 0.24
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Alastair McKinstry <mckinstry@debian.org>
Description:
kbd-chooser - Detect a keyboard and select layout (udeb)
Closes: 203135
Changes:
kbd-chooser (0.24) unstable; urgency=low
.
* Small error in keymap handling; patch thanks to Thomas Poindessous.
* kbd-chooser can't handle files other than console-keymaps-*; patch
from Thomas Poindessous. Closes: #203135.
* Change changelog to UTF-8 for Standards-Version 3.6.0
* Change maintainer-email to mckinstry@debian.org
Files:
d3e9bbd270642a58fe6a5d62e8fbc49d 686 debian-installer standard kbd-chooser_0.24.dsc
a276320791b12ecf5902906068285ea4 44343 debian-installer standard kbd-chooser_0.24.tar.gz
a0258410388c4e05778f0b19d742a784 26484 debian-installer standard kbd-chooser_0.24_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/JQIw+o43kJBROPQRAm9gAJ47d7Lcfva3uCFzZXqSr9Oyn84B6gCdEDxm
QfT5Ht803CrODPrcv0s4kjM=
=Re+Z
-----END PGP SIGNATURE-----
Reply to: