Re: Bug#891188: blends-dev: created d/control recommends packages not in main
Hi Ole,
On Thu, Mar 15, 2018 at 04:55:24PM +0100, Ole Streicher wrote:
> >
> > GENCONTROL_DEPENDS = true
> >
>
> Feel free to lower the severity.
I think there is no need to since I found the part of the code where the
issue occures. If I would only understand Perl a bit better I would be
ready with a fix. :-(
> However, that was a change of the
> default behaviour that we discussed a year ago: we wanted to remove the
> translation
>
> "Depends:" (tasks) -> "Recommends:" (d/control)
> "Recommends:" (tasks) -> "Suggests:" (d/control)
>
> in favour of a direct copy.
Its true that we agreed upon this and the code **seemed** to do this.
However, if there is no Depends -> Recommends the check whether the
missings need to be removed is simply not done.
> I am wondering why debian-astro is the only
> blend which finally used this, and I think we wanted to convert all.
I have not seen any reason to switch any behaviour since there are no
strict Depends in Debian Med. Thus I just substituted
s/Depends/Recommends/ inside the watch file "to be prepared" and be more
expclicit what we mean. But I had no reason to force any switch. Most
probably all other Blends did the same as I in Debian Med and thus you
were simply the only one who was stumbling upon this issue.
> > But I do not want to play severity ping-pong and will have a look
> > why GENCONTROL_DEPENDS is obviously breaking this.
>
> That is probably the code that was introduced for this purpose (August
> 2017).
It is
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 267) my $pkglist;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 268) my $missinglist;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 269) if (defined $taskinfo{$task}{Depends})
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 270) {
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 271) ($pkglist, $missinglist) = process_pkglist(join(",",@{$taskinfo{$task}{Depends}}));
36791f91 cdd/devtools/cdd-gen-control (Andreas Tille 2007-08-27 17:48:49 +0000 272) }
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 273)
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 274) my (@depends, @recommends, @suggests);
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 275)
0fc23d84 devtools/blend-gen-control (Mike Gabriel 2017-08-21 13:51:30 -0400 276) push @depends, $tasksname.' (= ${source:Version})';
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 277) push @depends, '${misc:Depends}';
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 278) push @depends, @{$pkglist}
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 279) if defined $pkglist;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 280)
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 281) push @recommends, @{$taskinfo{$task}{Recommends}}
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 282) if defined $taskinfo{$task}{Recommends};
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 283)
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 284) push @suggests, @{$missinglist}
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 285) if defined $missinglist;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 286) push @suggests, @{$taskinfo{$task}{Suggests}}
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 287) if defined $taskinfo{$task}{Suggests};
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 288)
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 289) my @depends_sorted = sort_uniq(\%seenlist, @depends);
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 290) my @recommends_sorted = sort_uniq(\%seenlist, @recommends);
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 291) my @suggests_sorted = sort_uniq(\%seenlist, @suggests);
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 292)
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 293) print("Depends: ",
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 294) join(",\n ", @depends_sorted),"\n")
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 295) if @depends_sorted;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 296) print("Recommends: ",
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 297) join(",\n ", @recommends_sorted),"\n")
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 298) if @recommends_sorted;
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 299) print("Suggests: ",
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 300) join(",\n ", @suggests_sorted),"\n")
a452586c devtools/blend-gen-control (Mike Gabriel 2017-08-11 23:39:29 -0400 301) if @suggests_sorted;
I'll see whether my Perl skills will be sufficient to get the
issue solved.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: