[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825172: blends-dev: please provide a way to create true depends]

On Tue, May 24, 2016 at 10:40:43AM +0000, Holger Levsen wrote:
> dist:
>         # the next two lines are taken from the original dist target
>         # from blends-dev Makefile
>         rm -f $(BLEND)-tasks.desc debian/control
>         make -f debian/rules get-orig-source
>         # This sed command removes gosa-plugin-netgroups from the list
>         # of Recommends and
>         # adds gosa-plugin-netgroups to Depends
>         # Closes: #793667
>         sed -i -e '/^ *gosa-plugin-netgroups,$$/d' \
>                -e '/^Package: education-main-server/{;N;N;N;N;s/\nDepends: [^\n]*/&, gosa-plugin-netgroups,/;}' \
>                debian/control
>         # regenerate source tarball after d/control was changed
>         make -f debian/rules get-orig-source
> As quite clearly indidcated by calling "make -f debian/rules get-orig-source"
> *twice*,

Well, since make is used the only "work" that's been done twice is
creating a 100kB tarball twice.  I agree that's not nice nor elegant but
it sounds more dramatic in your mail than it is in the end.  There is
not more effective time spent from a users point of view.

If you really mind about this you could copy more code from the original
blends Makefile template which is included and could go without this
duplication.  The drawback would be that if the Blends framework would
change you would miss this change in your Makefile.

As I said previously:  The Makefile stuff was created for your comfort
around the work horse blend-gen-control which is doing the dependency
resolution.  It somehow minimises the numbers of lines you need to write
on your own.  If you don't like it you can easily call blend-gen-control
manually change d/control and tar it up.  BTW, when using source format
3.0 (native) you do not even need any tarball any more.  So if you
like you could replace

    make -f debian/rules get-orig-source


    rm -f ../debian-edu_*.tar.xz

and there is no duplication at all.  Thinking twice about it it might
be even the best solution to skip the tarball creation at all since
dpkg-buildpackage will re-create it anyway.

Kind regards



Reply to: