[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Modify upgrade_bibtex.sql: Create function bibtex_debian_pool() which gets references for sources present only in the Debian Package Pool



Hi,

On Thu, Apr 23, 2015 at 05:25:05PM +0530, Akshita Jha wrote:
> I created a new function bibtex_debian_pool() which has an INNER JOIN and
> also escapes '#'. So, the query in generate_bibtex.py will change to :
> 
>    # create BibTeX file
>       bf = open(self.bibtexfile, 'w')
> 
>       if self.all_ref == 1:
>         query = "SELECT * FROM bibtex()"
>       else:
>       query = "SELECT * FROM bibtex_debian_pool()"
> 
>       cur.execute(query)
>       for row in cur.fetchall():
>           print >>bf, row[0]
> 
>       bf.close()
> 
> This is what you meant, right ?

Yes, this sounds correct.
 
> Now when I was looking at the patch, I think I have sent the wrong patch -
> missed a 'replace' in this one. If the approach is right, then I can resend
> the two patches for upgrade_bibtex.sql and also resend the patch creating
> "generate_bibtex.py" with the changes above for review.

Just tell me what patch you would consider "valid" and I'll review this
one / the latest. :-)

Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: