[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Make use of a separate script to generate debian.{bib,tex} files



Hi Akshita,

On Thu, Apr 23, 2015 at 11:25:35AM +0530, Akshita Jha wrote:
> 
> Can you review the patch above.

I'm a bit busy today but I hope to manage until tomorrow evening (@ GMT+2).

> I haven't replaced '#' with '\#' yet (my
> previous mail).

I noticed this.  I also noticed that you do not use the stored function
bibtex but rather add it manually.  I'd prefer to fix (and use) this
function since it enables testing separately from the python code and I
also published somewhere on a mailing list this option.  While I do not
think that it is used in real situations I think its better to stick to
this.  I have explained in my previous mail how to do this.

> I have got commit permissions for collab-qa. If everything
> looks fine then I can commit these changes to the repo.

That's fine.

BTW, when looking at the code I noticed that the change I recently did
in the references definition:

   https://wiki.debian.org/UpstreamMetadata?action=diff&rev2=100&rev1=99

also needs to be implemented in the bibref importer.  I also realised
that while ISSN is implemented for UDD it was lacking on the
specification page.  I just fixed this with the latest change in the
Wiki.

Kind regards

        Andreas.

-- 
http://fam-tille.de


Reply to: