Re: [PATCH] modify blends_prospective_gatherer.py: check if dpkg-parsechangelog exists

[Akshita Jha <zenith158@gmail.com>]

Hi,

On Sat, Apr 18, 2015 at 11:26 AM, Andreas Tille <andreas@an3as.eu> wrote:

Hi Akshita,

I applied your patch and commited another change:

           if errstring != '':
             self.log.warning("Error parsing changelog of '%s' of %s\n %s:" % (source, sprosp['blend'], errstring))
        else:
-         self.log.warning("dpkg-parsechangelog file does not exist - make sure dpkg-dev is installed")
+         self.log.error("dpkg-parsechangelog file does not exist - make sure dpkg-dev is installed")

         for stanza in deb822.Sources.iter_paragraphs(p.stdout):
           if source != stanza['source']:

since the missing dpkg-parsechangelog has a major effect on the result.
May be its even better to stop execution at all.

You are right. If dpkg-parsechangelog does not exist, then it is an error and the program should exit(1). I have sent a patch which does this.