[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: reform-tools_1.82-2~bpo13+1_both.changes REJECTED



Hi,

Quoting Adam D. Barratt (2025-12-06 11:07:10)
> On Sat, 2025-12-06 at 02:02 +0100, Johannes Schauer Marin Rodrigues
> wrote:
> > maye I'm really dumb and please assume I am because I might be
> > missing something really obvious. I am unable to find the file
> > reform-power-daemon.patch anywhere. It is certainly not part of
> > version 1.82-2. In fact there are no patches at all:
> > 
> > https://sources.debian.org/src/reform-tools/1.82-2/debian
> > 
> > And the topmost changelog "Rebuild for trixie-backports." is really
> > just that.
> > There are no other changes than the changelog entry. At least there
> > should be.
> > I don't understand what I am missing.
> 
> It does appear to be in the package that was uploaded:
> 
> adsb@coccia:~$ tar --wildcards -Jvtf /srv/ftp-master.debian.org/queue/reject/reform-tools_1.82-2~bpo13+1.debian.tar.xz "*patch"
> -rw-rw-r-- 0/0             677 2025-11-21 00:26 debian/patches/reform-power-daemon.patch

oh no... :(

Thank you for your thorough review and having found this. This file was not
included intentionally in my upload. It should not be there.

I probably should've done the upload to NEW with dgit instead of using dput to
make sure that I only upload what I have in my packaging git instead of also
including any other random file which happens to be there as well. I usually
don't use dgit for uploads to NEW because the upload might get rejected and
then dgit will know about a state which never entered the archive.

I now did a new upload to trixie-backports and verified that the only
difference to the version in testing (other than the broken symlinks) is
the additional entry in debian/changelog (diff at the end of this mail).

I hope that I didn't mess up anything else this time.

I am grateful for your thorough review and for having found this mistake.

Thanks!

cheers, josch

--- reform-tools-1.82/debian/changelog	2025-11-21 08:22:34.000000000 +0100
+++ reform-tools-1.82/debian/changelog	2025-11-29 07:50:37.000000000 +0100
@@ -1,3 +1,9 @@
+reform-tools (1.82-2~bpo13+1) trixie-backports; urgency=medium
+
+  * Rebuild for trixie-backports.
+
+ -- Johannes Schauer Marin Rodrigues <josch@debian.org>  Sat, 29 Nov 2025 07:50:37 +0100
+
 reform-tools (1.82-2) unstable; urgency=medium
 
   * enable and start reform-power-daemon by default upon installation and

Attachment: signature.asc
Description: signature


Reply to: