Re: Bug#747703: bpo60 vlc should not pull samba4 from bpo too

[Michael Tokarev <mjt@tls.msk.ru>]

11.05.2014 13:04, Michael Tokarev wrote:
> Backport of vlc to wheezy uses libsmbclient from samba4, which
> means that when installing vlc on a wheezy system, whole samba
> suite has to be upgraded too if samba is installed.
...
> I see the changelog entry in vlc:
> 
> 2.1.2-2~bpo70+1:
>   Tighten build dependencies on gettext, libsmbclient (for pkg-config
>   file) and libav9

It looks like just adding

 SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient

environment variables to ./configure invocation fixes this issue.
(SMBCLIENT_CFLAGS should not be empty or else it won't be recognized).

Indeed, in wheezy libsmbclient-dev there was no .pc file for
pkg-config, and samba4 configure switched to using pkg-config
to detect libsmbclient.

So there are 2 possible solutions for this issue:

1) add the above hack (which works for both 3 and 4 versions of
  libsmbclient), and

2) modify configure.ac to include previous test for libsmbclient,
  as found in vlc-2.0.

Note that 2) requires automake-1.4 to be available at build time
(which is not in wheezy).

Debdiff for case 1 is below.

Thanks,

/mjt

---
+vlc (2.1.2-2~bpo70+3) wheezy-backports; urgency=low
+
+  * lessen versioned build dependency on libsmbclient.
+
+ -- Michael Tokarev <mjt@tls.msk.ru>  Sun, 11 May 2014 16:18:18 +0400
+
 vlc (2.1.2-2~bpo70+2) wheezy-backports; urgency=low

   * No change rebuild.
diff -Nru vlc-2.1.2/debian/control vlc-2.1.2/debian/control
--- vlc-2.1.2/debian/control	2014-01-24 05:15:42.000000000 +0400
+++ vlc-2.1.2/debian/control	2014-05-11 16:18:17.000000000 +0400
@@ -77,7 +77,7 @@
                libsdl1.2-dev (>= 1.2.10),
                libshout3-dev,
                libsidplay2-dev,
-               libsmbclient-dev (>= 2:3.6.19),
+               libsmbclient-dev,
                libspeex-dev (>= 1.0.5),
                libspeexdsp-dev (>= 1.0.5),
                libssh2-1-dev,
diff -Nru vlc-2.1.2/debian/rules vlc-2.1.2/debian/rules
--- vlc-2.1.2/debian/rules	2014-01-11 18:21:03.000000000 +0400
+++ vlc-2.1.2/debian/rules	2014-05-11 16:18:09.000000000 +0400
@@ -240,7 +240,7 @@
 	dh_auto_clean

 override_dh_auto_configure:
-	dh_auto_configure -- $(confflags)
+	SMBCLIENT_CFLAGS=" " SMBCLIENT_LIBS=-lsmbclient dh_auto_configure -- $(confflags)

 override_dh_auto_test:
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))