[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: upload request for supernovas-1.3.0-1



Hi Thorsten, once again!


I take back the last one. The fact is that libsupernovas1 really should not include solarsystem / solarsystem_hp symbols, even as dummy implementations. These symbols are instead provided by the libsolsys1-1 and libsolsys2-1 subpackages, which means that if libsupernovas1 also provides these, then the subpackages are rendered unusable because of the duplicated symbols. These symbols belong to the optional subpackages only, and have no place in the main libsupernovas1 package. Thus, their removal in 1.3.0 actually unbreaks what was broken in 1.2.0 (and before).

In the upstream changelog it is listed as a bug fix for issue #139.

-- A.



On 4/18/25 9:23 AM, Attila Kovacs wrote:
Hi Thorsten again,


PS. If you prefer, I can reinstate these symbols as a patch with dummy implementations that merely return an error. As mentioned before, they are meant for supporting legacy code developed for NOVAS C 3.1 only, in which the user provides these as custom implementations. The packaged builds are not really supporting this type of legacy appication. If someone wants to use SuperNOVAS with such legacy code, they would have to custom build SuperNOVAS from source anyway, instead of using the packaged libs.

-- A.


On 4/18/25 9:17 AM, Attila Kovacs wrote:
Hi Thorsten,


The symbols you mentioned were included by mistake in the previous releases. They were never meant to be included in the first place. Both the solarsystem and solarsystem_hp are reserved for legacy user implementations outside of the scope of the packaged libraries, and hence they are not meant to be provided by the packaged supernovas libraries themselves. I made a mistake in the build configuration in the releases prior to 1.3.0, which is how they were erroneously present, despite the intent. v1.3.0 merely corrects that mistake.

-- A.



On 4/17/25 7:07 PM, Thorsten Alteholz wrote:
Hi Attila,

On Tue, 15 Apr 2025, Attila Kovacs wrote:
The CI build is clean, and I am looking for someone to upload it to Debian.

I just recognized that v1.2.0 contains for example symbols solarsystem@Base and solarsystem_hp@Base. Those are not available in v1.3.0. However you didn't change the soname of the library.
Did this happen intentional?

  Thorsten



Reply to: