Re: Help needed for supernovas v1.1.1 update / upload
On Wed Oct 30, 2024 at 5:16 PM IST, Attila Kovacs wrote:
> Hi Nilesh!
>
> OK, I followed your advice and removed README-orig.md from
> debian/libsupernovas-dev.docs. The CI now passes.
I was just curious to ask - is there a reason to remove
https://salsa.debian.org/debian-astro-team/supernovas/-/blob/debian/1.0.1-2-2/Makefile?ref_type=tags#L19
Just restoring it will do the trick. Seems I forgot to include URLs in
the previous mail. (One of the links was the above one).
> Thanks for the help (as always)!
>
> -- A.
>
>
> On 10/30/24 11:12 AM, Nilesh Patra wrote:
> > Hi Attila,
> >
> > On 30/10/24 14:53, Attila Kovacs wrote:
> >> Hi Nilesh,
> >>
> >>
> >> Thanks for the quick feedback.
> >>
> >>> This is not the real issue. You seem to have added README-orig.md in
> >>> debian/libsupernovas-dev.docs which is an arch:any package while
> >>> this is getting
> >>> created in only the arch:all part - and libsupernovas-doc won't
> >>> build on arch:any builds. I think removing it from there will do the
> >>> trick.
> >>>
> >> I'm just a little puzzled how it's a new issue. README-orig.md was
> >> part of the build before too. No change there. And I have not 'added'
> >> it to debian/libsupernovas-dev.docs since the last package either.
> >> And nothing changed in debian/control either...
> >
> > Sorry for not pin pointing the issue clearly to you - I see how that
> > led to confusion.
> >
> > So, if you see the test-any log of an older build[1] you would observe
> > this in the log:
> >
> > | WARNING! Doxygen is not available. Will skip 'dox' target
> > | mkdir lib
> > | LINE=`sed -n '/\# /{=;q;}' README.md` && tail -n +$((LINE+2))
> > README.md > README-orig.md
> >
> > The sed line here is creating the orig.md however, you won't see it in
> > the latest log (the sed line is missing). This is because in the
> > previous release, you had a
> >
> > | # The documentation components to build
> > | DOC_TARGETS := README-orig.md
> >
> > in your makefile see [2]. This is now removed in the latest code that
> > you pushed to salsa (I am not sure why?). And since README-orig.md is
> > no longer a part of DOC_TARGET when
> > doxygen is absent and the -dev package tries to install the orig.md
> > file, it chokes.
> >
> > Please feel free to ask again if at all there's still some confusion.
> >
> >> Since README-orig.md is part of the developer focused documentation,
> >> I do think it belongs to debian/libsupernovas-dev.docs. Perhaps
> >> libsupernovas-dev should be arch:all instead of arch:any?
> >
> > That can happen only if the package contains architecture-independent
> > files. Since the package has .so files installed in arch-specific
> > location, we can't make it arch:all.
> >
> >>
> >> Let me know what you think.
> >>
> >> cheers,
> >>
> >> -- A.
> >>
> >
> > Thanks
> > Nilesh
> >
Reply to: