[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: supernovas upstream update -- needs sponsor



Hi Nilesh!

Thanks. Your changes look good to me. I like the <!cross> feature, and if the overrides in rules do what you expect them to do, then that's good by me also.

-- A.


On 6/2/24 4:19 PM, Nilesh Patra wrote:
Hi!

Turns out I was wrong on both the counts -- sorry!

On Sun, Jun 02, 2024 at 03:50:38PM +0200, Attila Kovacs wrote:
Uhm. Unless I am mistaken, make will run the "make all" rule and in the all
rule in your makefile, you've specified "test coverage" etc as seen here[2].
This will hence run at build time, and not just dh_auto_test.
Well, if 'dh_auto_build' runs 'make all' (and not simply 'make' with the
default target), then this can be easily fixed by providing an override rule
that simply calls 'make' (or the equivalent 'make distro') in debian/rules.
I'm happy to make the change if you agree.
You are right. Seems I saw something wrong somewhere. For your package it should
call make distro.

It will be provided by the native build -- there should be no issue there as
such. As such, I don't think it is possible to exclude selected binary packages
from cross-compiling, but I might need to think a bit more here.
Moments after sending this, I realised it is possible to skip things per
package. It can be done with adding in <!cross> build profile.

I have pushed a couple of commits to salsa. Do let me know what you'd think.

If, as you say, the aarch64 packages are provided by native builds, then
there is no issue with the cio_ra.bin file (and the 'supernovas-cio-data'
sub-package that provides it). It's only the cross-build setup that cannot
produce these.
Yep, since we can't run a binary compiled for aarch64 on amd64.

Best,
Nilesh


Reply to: