Re: Fixing build for Siril

[Ole Streicher <olebole@debian.org>]

Hi Cyril,

you just removed the patch, which also didn't work. I re-added it now
and changed "-fno-common" to "-fcommon", which works, and uploaded this one.

Cheers

Ole

On 31.07.20 08:55, Cyril Richard wrote:
> Dear Ole,
> 
> You're right.
> 
> I've fixed it.
> 
> Le ven. 31 juil. 2020 à 08:42, Ole Streicher <olebole@debian.org
> <mailto:olebole@debian.org>> a écrit :
> 
>     Hi Cyril,
> 
>     Cyril Richard <cyril.richard42@gmail.com
>     <mailto:cyril.richard42@gmail.com>> writes:
>     > Hello, I've uploaded a patch to fix the bug #957805.
>     > Please, could someone upload the fix to master.
>     >
>     > I have to say that I sadly did not test it as usual with pbuilder as
>     > I've no more space left on my / device. I'm working on it....  But the
>     > issue is trivial and was fixed some time ago in master.
>     >
>     > I think it should be fine. Let me know if everything is ok.
> 
>     Almost ;-)
> 
>     But you should use "-fcommon" to allow multiple symbols for the quick
>     fix. Currently, I see a
> 
>     g++  -Werror=unknown-pragmas -Werror=unused-label -fno-common [...]
>     -o siril main.o [...]
>     /usr/bin/ld: algos/pave.o:./src/./algos/Def_Wavelet.h:78: multiple
>     definition of `mallat_plan_des';
>     algos/io_wave.o:./src/./algos/Def_Wavelet.h:78: first defined here
>     /usr/bin/ld: algos/reconstr.o:./src/./algos/Def_Wavelet.h:78:
>     multiple definition of `mallat_plan_des';
>     algos/io_wave.o:./src/./algos/Def_Wavelet.h:78: first defined here
>     [...]
>     collect2: error: ld returned 1 exit status
> 
>     Best
> 
>     Ole
>