Re: Request for NEAT packaging review
Hi Roger,
all OK, I uploaded the package. Since this goes to NEW, be patient; it
may take a while to get accepted.
Cheers
Ole
Roger Wesson <rw@nebulousresearch.org> writes:
> Ah, OK, I will remove the -DBUILDDATE from future versions. I just
> uploaded a revised rules file to finally take care of the permissions issue.
>
> Thanks!
> Roger
>
> On 11/05/16 17:47, Ole Streicher wrote:
>> Hi Roger,
>> Roger Wesson <rw@nebulousresearch.org> writes:
>>> OK, I think everything is fixed - I'd removed all the old files from
>>> master when cleaning up my previous packaging attempt and had not
>>> readded them correctly. The script is executable and I updated the
>>> Standards-Version number. Hope that's all fine now.
>>
>> The script is still not executable. Reason is that the package is
>> actually built from the sources in the tarball, not from the git.
>>
>> The simplest way to fix this (without releasing a new version) is to add
>>
>> override_dh_fixperms:
>> dh_fixperms
>> chmod a+x debian/neat/usr/share/neat/plot.sh
>>
>> to debian/rules.
>>
>> One point that I forgot: you include a -DBUILDDATE=... in your
>> Makefile. While may help for debugging, it makes the build
>> unreproducible. See https://wiki.debian.org/ReproducibleBuilds for
>> Details. You could either remove this completely, or replace the build
>> date with the release date (taken f.e. from debian/changelog) if you
>> really need it. This is not a show-stopper (I will upload you package
>> independent of this), but please think about this for the next version.
>>
>> Best regards
>>
>> Ole
>>
Reply to: