Re: Request for NEAT packaging review
Hi Ole,
Thanks for the review! I have uploaded new files, in which I have
updated the copyright and control files, renamed the .orig tar file,
removed the empty docs file, and changed the makefile to allow
propagation of FFLAGS and LDFLAGS. I prefer to retain the O3 flag in
the makefile, if possible, as there is a significant performance gain
compared to O2. The example files should have been set to install in
the first version I uploaded - maybe I missed something?
Thanks for any further comments!
Roger
On 13/04/16 07:55, Ole Streicher wrote:
> Hi Roger,
>
> thank you for preparing the package. I have a few comments:
>
> * debian/copyright: Document the copyright of all files, not just the
> debian ones.
>
> * debian/control:
> - The section should be "science", not "misc".
> - Could you provide a little longer description?
>
> * the .orig file in the "pristine-tar" branch should be called
> neat_1.9.orig.tar.gz, not neat_1.90.orig.tar.gz
>
> * Propagate FFLAGS and LDFLAGS, and enable debug symbols. They are
> stripped afterwards from the package, but will go into a separate
> package to enable debugging if needed. Also, the optimization should
> be set by the Debian FFLAGS unless there is a special reason not to do
> so.
>
> * Since you provide example wit the sources, please install them.
>
> * Remove the empty file debian/docs.
>
> Best regards
>
> Ole
>
> Roger Wesson <rw@nebulousresearch.org> writes:
>> I have uploaded my package of NEAT (Nebular Empirical Analysis Tool) to
>> http://anonscm.debian.org/cgit/debian-astro/packages/neat.git/
>> It's ready to be reviewed. Thanks in advance for all comments and
>> corrections!
>
Reply to: