Re: RFC: casacore-2.1.0-1 debian package

[Ole Streicher <olebole@debian.org>]

Hi Benda,

Benda Xu <heroxbd@gmail.com> writes:
> I have just pushed my working branch of casacore packaging to
>   https://anonscm.debian.org/cgit/debian-astro/packages/casacore.git
> I consider it ready to be uploaded. Please have a review and share your
> thoughts.

I didn't check the licensing stuff yet (I'll do this tomorrow), but for
the rest I have just three comments:

* Since the ITP bug was untouched for a while, it automatically got
  renamed to an RFP, with you as the owner removed. Could you re-title
  it into an ITP, and set yourself as the owner? This also applies to
  casacore-data.

* I get a compilation error when casa_python is built:

cd /build/casacore-2.1.0/obj-x86_64-linux-gnu/python && /usr/lib/ccache/c++   -DCFITSIO_VERSION_MAJOR=3 -DCFITSIO_VERSION_MINOR=380 -DHAVE_FFTW3 -DHAVE_FFTW3_THREADS -DHAVE_READLINE -DUSE_THREADS -DWCSLIB_VERSION_MAJOR=5 -DWCSLIB_VERSION_MINOR=14 -Dcasa_python_EXPORTS -I/build/casacore-2.1.0 -I/build/casacore-2.1.0/obj-x86_64-linux-gnu -I/usr/include/python2.7  -fcx-fortran-rules -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -pthread -fPIC   -o CMakeFiles/casa_python.dir/Converters/PycArray.cc.o -c /build/casacore-2.1.0/python/Converters/PycArray.cc
In file included from /build/casacore-2.1.0/casacore/python/Converters/PycArray.tcc:32:0,
                 from /build/casacore-2.1.0/python/Converters/PycArray.cc:30:
/build/casacore-2.1.0/casacore/python/Converters/PycArrayNP.h:38:31: fatal error: numpy/arrayobject.h: No such file or directory

 You should include python-numpy in the build dependencies.

* Please create a "pristine-tar" branch and commit there (with the
  pristine-tar command) the source tarball.

Best regards

Ole