Re: [Help] Re: Bug#969552: phipack: arm64 autopkgtest failure: ERROR: Illegal state encountered: �
On Tue, Sep 08, 2020 at 05:35:45PM -0400, Lennart Sorensen wrote:
> On Tue, Sep 08, 2020 at 10:35:26PM +0200, Andreas Tille wrote:
> > Control: tags -1 help
> >
> > Hi Debian Arm team,
> >
> > I admit I have no idea how to deal with this except by excluding
> > arm64 from the list of supported architectures which is definitely
> > not my prefered way of action.
> >
> > Any help would be really appreciated.
>
> I don't have access to an arm64 system at the moment, but a good start
> might be to fix the compiler warnings, such as the array subscript out
> of bounds in global.c line 44. The rest of the warnings appear harmless.
>
> It would appear that GAP_SIZE = 2 is wrong given GAP[] only contains a
> single character.
I found the actual problem. Someone didn't know that there are 3 types
of char in C. char, signed char and unsigned char. char is _only_ for
use in strings, and never to be used as a numerical value. This is due
to the sign of char being implementation specific. On x86 it is signed,
on arm it is unsigned. So any time you want to work with numerical
values of a char, you must specify if you want signed or unsigned.
Changing char ch to unsigned char ch, made x86 fail the same way arm64
did, and making it signed char, makes both pass the test.
So here is a patch that appears to solve the problems in the code.
--
Len Sorensen
diff -ruN phipack-0.0.20160614/src/fasta.c phipack-0.0.20160614.arm64/src/fasta.c
--- phipack-0.0.20160614/src/fasta.c 2016-06-14 00:18:29.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/fasta.c 2020-09-08 19:08:06.672390326 -0400
@@ -36,7 +36,7 @@
void read_sequence_name(FILE *in_file,char *name, int capacity)
{
int i=0;
- char ch='\0';
+ signed char ch='\0';
ch=fgetc(in_file);
if(ch != '>')
@@ -97,7 +97,7 @@
{
int bases_read=0;
int new_limit;
- char ch;
+ signed char ch;
char s[250];
ch=fgetc(in_file);
@@ -175,7 +175,7 @@
int *seq_counter;
int i;
- char ch;
+ signed char ch;
int cur_seqs;
int num_seqs=1,new_num;
diff -ruN phipack-0.0.20160614/src/global.c phipack-0.0.20160614.arm64/src/global.c
--- phipack-0.0.20160614/src/global.c 2016-06-13 22:33:15.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/global.c 2020-09-08 18:04:48.956444973 -0400
@@ -34,7 +34,7 @@
const int AA_AMBIG_SIZE =2;
const char GAP[] = {'-'};
-const int GAP_SIZE=2;
+const int GAP_SIZE=1;
cbool memberOf(const char *set, const int num, char ch)
{
@@ -79,10 +79,10 @@
switch(alignKind)
{
case DNA:
- return (memberOf(DNA_MISSING,DNA_MISSING_SIZE,ch) || memberOf(DNA_AMBIG,DNA_AMBIG_SIZE,ch));
+ return (memberOf(DNA_MISSING,DNA_MISSING_SIZE,ch) || memberOf(DNA_AMBIG,DNA_AMBIG_SIZE,ch)) ? TRUE : FALSE;
break;
case AA:
- return (memberOf(AA_MISSING,AA_MISSING_SIZE,ch) || memberOf(AA_AMBIG,AA_AMBIG_SIZE,ch));
+ return (memberOf(AA_MISSING,AA_MISSING_SIZE,ch) || memberOf(AA_AMBIG,AA_AMBIG_SIZE,ch)) ? TRUE : FALSE;
break;
case OTHER:
if(ch == GLOBAL_MISSING)
diff -ruN phipack-0.0.20160614/src/main.c phipack-0.0.20160614.arm64/src/main.c
--- phipack-0.0.20160614/src/main.c 2016-06-14 00:18:17.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/main.c 2020-09-08 19:17:18.230153542 -0400
@@ -71,7 +71,8 @@
void get_params(int argc, char**argv, options *opt)
{
- char *cur,ch,nextch;
+ char *cur;
+ signed char ch,nextch;
char temp[MAX_SIZE+1];
int i;
cbool inFileFound=FALSE;
diff -ruN phipack-0.0.20160614/src/mem.c phipack-0.0.20160614.arm64/src/mem.c
--- phipack-0.0.20160614/src/mem.c 2016-06-13 22:33:15.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/mem.c 2020-09-08 19:12:52.415278666 -0400
@@ -96,7 +96,7 @@
char ffclose(FILE *handle)
{
- char f;
+ signed char f;
char s[MAX_SIZE+1];
f=fclose(handle);
diff -ruN phipack-0.0.20160614/src/misc.c phipack-0.0.20160614.arm64/src/misc.c
--- phipack-0.0.20160614/src/misc.c 2016-06-13 22:33:15.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/misc.c 2020-09-08 19:08:28.352322441 -0400
@@ -46,7 +46,7 @@
char skip_all_space(FILE *in_file)
{
- char ch;
+ signed char ch;
ch=fgetc(in_file);
while((ch != EOF) && isspace(ch))
@@ -61,7 +61,7 @@
char skip_newlines(FILE *in_file)
{
- char ch;
+ signed char ch;
ch=fgetc(in_file);
while((ch != EOF) && (ch == '\n'))
@@ -76,7 +76,7 @@
char skip_non_newline(FILE *in_file)
{
- char ch;
+ signed char ch;
ch=fgetc(in_file);
while((ch != EOF) && (ch != '\n'))
@@ -90,7 +90,7 @@
char skip_non_newline_space(FILE *in_file)
{
- char ch;
+ signed char ch;
ch=fgetc(in_file);
while((ch != EOF) && (ch != '\n') && isspace(ch))
diff -ruN phipack-0.0.20160614/src/phylip.c phipack-0.0.20160614.arm64/src/phylip.c
--- phipack-0.0.20160614/src/phylip.c 2016-06-14 00:18:17.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/phylip.c 2020-09-08 19:10:06.483985652 -0400
@@ -30,7 +30,7 @@
void read_strict_name(FILE *in_file,char *name, int capacity)
{
int i;
- char ch='\0';
+ signed char ch='\0';
for(i=0;(i<PHYLIP_SIZE) && (ch!=EOF);i++)
{
ch=fgetc(in_file);
@@ -51,7 +51,7 @@
void read_relaxed_name(FILE *in_file,char *name, int capacity)
{
int i=0;
- char ch='\0',next_ch;
+ signed char ch='\0',next_ch;
cbool double_space=FALSE;
while((i<capacity) && (ch!=EOF) && (double_space == FALSE))
@@ -129,7 +129,7 @@
int read_seq_bit(FILE *in_file, int base_limit, align_type* states, int index, int *num_bases)
{
int bases_read=num_bases[index];
- char ch;
+ signed char ch;
char s[250];
ch=fgetc(in_file);
@@ -213,7 +213,7 @@
int *seq_counter;
int i;
int cur_seq=0;
- char ch;
+ signed char ch;
in_file=fopen(file_name,"r");
if(in_file == NULL)
diff -ruN phipack-0.0.20160614/src/profile.c phipack-0.0.20160614.arm64/src/profile.c
--- phipack-0.0.20160614/src/profile.c 2016-06-14 00:18:17.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/profile.c 2020-09-08 19:16:45.274292568 -0400
@@ -71,7 +71,8 @@
void get_params(int argc, char**argv, options *opt)
{
- char *cur,ch,nextch;
+ char *cur;
+ signed char ch,nextch;
char temp[MAX_SIZE+1];
int i;
cbool inFileFound=FALSE;
diff -ruN phipack-0.0.20160614/src/seqManip.c phipack-0.0.20160614.arm64/src/seqManip.c
--- phipack-0.0.20160614/src/seqManip.c 2016-06-14 00:18:17.000000000 -0400
+++ phipack-0.0.20160614.arm64/src/seqManip.c 2020-09-08 19:14:37.974830794 -0400
@@ -190,7 +190,7 @@
cbool validate_alignment(align_type **alignment, alignmentClass alignKind,int num_taxa, int num_sites)
{
int i,j;
- char ch;
+ signed char ch;
char s[MAX_SIZE+1];
for(i=0;i<num_taxa;i++)
Reply to: