[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH V2] d-i hd-media support for armhf



On 2014-09-30 15:47:13 -0700, Karsten Merker wrote:
>   * Add the "console=" parameter to bootargs only if ${console}
>     is set.
...
> diff --git a/build/boot/arm/bootscr.mainline_common b/build/boot/arm/bootscr.mainline_common
...
> +if test -z "${console}"; then
> +  setenv bootargs "${bootargs} console=${console}"
> +fi

That looks backwards, it'll only set console= when ${console} is
empty... possibly overwriting a valid value in bootargs...


Other than that, it looks pretty good to me. Thanks for your good work!


live well,
  vagrant

Attachment: pgp1MaIx61Zif.pgp
Description: PGP signature


Reply to: