[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#743787: dns323-firmware-tools: breaks armel d-i builds since ruby-defaults 1:2.0.0.1 hit unstable



* Cyril Brulebois <kibi@debian.org> [140406 15:51]:
[ shuffling your message a bit ]
> since this upload[1],
>  1. http://packages.qa.debian.org/r/ruby-defaults/news/20140330T152352Z.html

dns323-firmware-tools depends on ruby1.9.1 but then just uses
/usr/bin/ruby in the shebang, rendering the dependency on a specific
interpreter version useless and wrong.

> we're getting a failure when building the armel
> orion5x_network-console flavour:
> | mkdns323fw -k ./tmp/orion5x_network-console/dns-323/kernel.uboot -i ./tmp/orion5x_network-console/dns-323/initrd.uboot -p 7 -c 1 -m 1 -o ./dest/orion5x/network-console/d-link/dns-323/netboot.img
> | /usr/bin/mkdns323fw:73: invalid multibyte escape: /^\x55\xAA(.{7})\0\x55\xAA$/
> | make[2]: *** [dns-323] Error 1

I haven't tried with actual files, but it looks like this change
might work on 1.9 and 2.0:

--- mkdns323fw~ 2014-04-07 00:07:27.560331402 +0200
+++ mkdns323fw  2014-04-07 00:08:39.796220588 +0200
@@ -70,7 +70,7 @@
        
        # Return the signature of this firmware file.
        def signature
-               if @signature =~ /^\x55\xAA(.{7})\0\x55\xAA$/
+               if @signature =~ Regexp.new("^\x55\xAA(.{7})\x55\xAA$".force_encoding("binary"), Regexp::FIXEDENCODING)
                        return $1
                else
                        raise RuntimeError.new("Unparseable signature string: #{@signature.inspect}")


  -ch

-- 
 ,''`.  Christian Hofstaedtler <zeha@debian.org>
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-

Attachment: pgpRRl8CJmMrn.pgp
Description: PGP signature


Reply to: