Re: #215067 mozilla FTBFS
tags 215067 patch
thanks
On Thu, 2003-10-23 at 14:07, Philip Blundell wrote:
> On Thu, 2003-10-23 at 13:40, Adam C Powell IV wrote:
> > Is it secretly big-endian for
> > its float/double emulation, and little-endian for ints?
>
> More or less, yeah. It's actually only doubles that are affected.
>
> I suggest you try changing
>
> #if defined(IS_LITTLE_ENDIAN)
>
> into
>
> #if defined(IS_LITTLE_ENDIAN) && (!defined(__arm__) ||
> defined(__VFP_FP__))
>
> and see if that improves matters at all.
Indeed, with that change, shlibsign works! During that call to PR_dtoa,
d2=1.0, ds=~0.03, which seems to be what it's supposed to be.
I've patchified this in a form which can be stuck into debian/patches
(attached), and is building now, will report back on the (likely built,
hopefully working) package in ~24 hours.
Thanks!
--
-Adam P.
GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6
Welcome to the best software in the world today cafe!
http://lyre.mit.edu/~powell/The_Best_Stuff_In_The_World_Today_Cafe.ogg
--- mozilla/nsprpub/pr/src/misc/prdtoa.c.~3.7.4.3.~ Tue Jan 7 10:30:15 2003
+++ mozilla/nsprpub/pr/src/misc/prdtoa.c Thu Oct 23 20:09:19 2003
@@ -129,7 +129,7 @@
* is not strictly legal and can cause trouble with aggressively
* optimizing compilers (e.g., gcc 2.95.1 under -O2).
*/
-#if defined(IS_LITTLE_ENDIAN)
+#if defined(IS_LITTLE_ENDIAN) && (!defined(__arm__) || defined(__VFP_FP__))
#define IEEE_8087
#else
#define IEEE_MC68k
Reply to: