[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#900612: marked as done (apache2-suexec-pristine: Packaging steps undo setting of setuid bit)



Your message dated Fri, 05 Dec 2025 06:04:39 +0000
with message-id <E1vROvn-00GOCO-1W@fasolo.debian.org>
and subject line Bug#900612: fixed in apache2 2.4.66-1
has caused the Debian Bug report #900612,
regarding apache2-suexec-pristine: Packaging steps undo setting of setuid bit
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
900612: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900612
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: apache2-suexec-pristine
Version: 2.4.25-3+deb9u4
Severity: normal
Tags: patch
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

When building the apache2-suexec-pristine (and apache2-suexec-custom) packages
from source, I expected the built .deb packages to contain setuid binaries
(at /usr/lib/apache2/suexec-pristine and /usr/lib/apache2/suexec-custom
respectively). However, when packaging was done, the packages contained
binaries with the permissions 0754, not 4754, as set in the debian/rules file.

Looking into this more, it appears that chgrp (through the chown system call)
clears the setuid bit (and all bits in the first octet of permissions) when it
is run, so the steps in override_dh_fixperms-arch end up removing the setuid
bit when chgrp is run after chmod.

This appears to be a problem in the source for this package, on the master
branch, as well as on separate branches for different distros:
https://salsa.debian.org/apache-team/apache2/blob/master/debian/rules#L148-153
I'm not sure how this has worked properly to produce packages, since the last
change to that section was 6 years ago, so I'm a bit confused on that point.

Here is a patch to fix the setting of the setuid bit in both packages by just
moving the chmod to after chgrp has already run:

--- debian/rules
+++ debian/rules
@@ -146,11 +146,11 @@ override_dh_install: clean-config-vars-stamp \

 override_dh_fixperms-arch:
        # standard suexec
-       chmod 4754 debian/apache2-suexec-pristine/usr/lib/apache2/suexec-pristine
        chgrp www-data debian/apache2-suexec-pristine/usr/lib/apache2/suexec-pristine
+       chmod 4754 debian/apache2-suexec-pristine/usr/lib/apache2/suexec-pristine
        # configurable suexec
-       chmod 4754 debian/apache2-suexec-custom/usr/lib/apache2/suexec-custom
        chgrp www-data debian/apache2-suexec-custom/usr/lib/apache2/suexec-custom
+       chmod 4754 debian/apache2-suexec-custom/usr/lib/apache2/suexec-custom
        dh_fixperms -a -Xusr/lib/apache2/suexec-custom -Xusr/lib/apache2/suexec-pristine
        chown -R www-data:www-data debian/apache2/var/cache/apache2/mod_cache_disk
        chown root:adm debian/apache2/var/log/apache2


-- System Information:
Debian Release: 9.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Source: apache2
Source-Version: 2.4.66-1
Done: Yadd <yadd@debian.org>

We believe that the bug you reported is fixed in the latest version of
apache2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 900612@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yadd <yadd@debian.org> (supplier of updated apache2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 05 Dec 2025 06:35:34 +0100
Source: apache2
Architecture: source
Version: 2.4.66-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Yadd <yadd@debian.org>
Closes: 713967 860087 900612 913094 927302 1091855 1105015 1121926
Changes:
 apache2 (2.4.66-1) unstable; urgency=medium
 .
   [ Laurent Bigonville ]
   * Enable systemd module (Closes: #860087).
   * debian/apache2ctl: Fix the restart and greceful when using system.
     When apache is not running and restart or greceful is called, apache
     was running in the user cgroup and system was be confused
     (Closes: #927302).
     This will also avoid to leak fd to apache
     (Closes: #713967).
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #913094)
     + Annotate perl build dependency with :any.
     + cross.patch: Use AC_PATH_TOOL to find pkg-config.
     + Generate server/test_char.h ahead of the build
 .
   [ Jason Perrin ]
   * Fix packaging steps undo setting of setuid bit
     (Closes: #900612)
 .
   [ Bastien Roucariès]
   * Harden systemd services. Set ProtectSystem=full
     ProtectHome=read-only, RestrictSUIDSGID=yes.
     This may break read-write CGI script to /home and
     WebDaV or other CGI/php/lua uses.
   * Move /var/run to /run and /var/lock to /run/lock
   * Allow CAP_SYS_CHROOT for chroot
     (Closes: #1091855)
   * Remove apache2 IPC
 .
   [ Moritz Schlarb ]
   * Support Rules-Requires-Root: no (Closes: #1105015)
 .
   [ Yadd ]
   * New upstream version (Closes: #1121926, CVE-2025-55753, CVE-2025-58098,
     CVE-2025-59775, CVE-2025-65082, CVE-2025-66200)
Checksums-Sha1: 
 353539cbd2a956141089d588d38ff4e89cb04113 3582 apache2_2.4.66-1.dsc
 9a2de37ab3a9e4603a0a98f4e2255a6bfed005d4 9828043 apache2_2.4.66.orig.tar.gz
 a0525bf2f2f51a508b61d7d78e3dca19276de0d0 833 apache2_2.4.66.orig.tar.gz.asc
 757d7919f2d453f71d2a8cd4768e474f349dc29c 828600 apache2_2.4.66-1.debian.tar.xz
Checksums-Sha256: 
 d54458d3c50920ec869701d87b57ab433f0b40777902f2f7f427bbf0793edff4 3582 apache2_2.4.66-1.dsc
 442184763b60936471b88a91275f79d2407733b7aac27e345f270e8bc31c3d49 9828043 apache2_2.4.66.orig.tar.gz
 d39cdcb8d723e3c5bd4edc1e248d52c4fd352fb10eeda91cae973b12325605bc 833 apache2_2.4.66.orig.tar.gz.asc
 cbc7a62876ef92efce41dd3bdfa4bdd6f299ce47a203de39e61cab7ba95de161 828600 apache2_2.4.66-1.debian.tar.xz
Files: 
 0146a571ee98c8af7da73af2f078a349 3582 httpd optional apache2_2.4.66-1.dsc
 91b20bb90cf7d1eeb225e5b7246ce93d 9828043 httpd optional apache2_2.4.66.orig.tar.gz
 2823799bf1d4b8e771a672d1d6f6ce60 833 httpd optional apache2_2.4.66.orig.tar.gz.asc
 106d6b2885fdf73cf6e579634429a9b6 828600 httpd optional apache2_2.4.66-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmkycRYACgkQ9tdMp8mZ
7ukinQ//V3nDfUF9f6NvA4VoiWPQAsIfgabVNhDed/fX27WSwGt7A/AXykLje/By
P2+WWs6BbJcDaZby6E2iHXFwd3jx22hlItBV2lzr1Q0Kex2O23bAaqtk5qjhD5No
1n7rRAQtgmKHDtpkpPle0Z4FMJf3BxVdfYOvHyr3mTAkyYZqktcKtrFK9Kzo0J9B
kquKsvDNDo/SynUScjMX7L+VBxS4FQwJ2B6gY2iEI6guBhUmVS3RWRFQjh7iLSVX
anuegojZyxx2HFGFgLs56Bt81+KItBWoWbLr3kwD26s9ZCS/ViUMyA+JGhDu4cqu
EzstdVIGIiPSMHV+9gEeO5lPIirNo1vSiOKPxVoPdkQtOgWC/LlgxUPbMUv+gwtP
gDbWcialKhhRNn57ky7Jl9cB6J3wns7MslYZPRerAidXepNaXmMBrouGqlAZ0ofQ
NSXfKl7OwXc7JErG+tC9xpldTYsmcvECImhk8DlqyHP6Jz3lACIxLnm71xyXWLq5
cxx4LaFdQqLdDHFOzf/YtJdDxomlugnGgViNhfmtb4urrD0WTcE8JUl/ZpcAS39g
ys4MCWMq43pdks+cfW1gw591BbHmUpZdrjozq3EOQXK6BP651QCiDIi7jIxA6pT+
LXzwEcEv54nl+D644AHD2Um+m5EKfXb170jMe/4vXkhUPDs8s5Y=
=hVr9
-----END PGP SIGNATURE-----

Attachment: pgpvZIJUXBcsB.pgp
Description: PGP signature


--- End Message ---

Reply to: