[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107289: marked as done (Apache2 2.4.63-1 has a failing test in its test suite)

Your message dated Mon, 11 Aug 2025 19:19:09 +0000
with message-id <E1ulY33-00HIkL-1m@fasolo.debian.org>
and subject line Bug#1107289: fixed in apache2 2.4.65-3
has caused the Debian Bug report #1107289,
regarding Apache2 2.4.63-1 has a failing test in its test suite
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107289: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107289
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---

Source: apache2
Tags: fixed-upstream patch
Version: 2.4.63-1
Severity: normal

Discovered downstream in Ubuntu during migration tests.

Downstream bug: https://bugs.launchpad.net/bugs/2112429

------

Downstream bug summary:

Discovered through update_excuses and confirmed locally in an LXD autopkgtest container (from https://github.com/canonical/ubuntu-maintainers-handbook/blob/main/PackageTests.md to create it), the autopkgtests on 2.4.63-1ubuntu2 fail for apache2's test suite.

It fails on debian/perl-framework/t/apache/pr64339.t, test #12 which makes sure certain content is rendered by xml2enc's backend components.

I followed every single step and reproduced in a pure LXD container with the apache2 binaries in proposed.

With this in mind, the following is the specific items in the test at fault:

EXPECTED: response from looking at http://localhost:8529/modules/xml2enc/front/doc.isohtml with a GET call is "<html><body><p>fóó\n</p></body></html>" and is UTF-8 encoded

ACTUAL: response from looking at http://localhost:8529/modules/xml2enc/front/doc.isohtml with a GET call is "<html><body>fóó\n</body></html>"

There is a changelog that introduces this test via a pull request:
  *) mod_xml2enc: Update check to accept any text/ media type
     or any XML media type per RFC 7303, avoiding
     corruption of Microsoft OOXML formats. PR 64339.
     [Joseph Heenan joseph.heenan fintechlabs.io, Joe Orton]

... in 2.4.59 in April 2024. At the time the test was written, Apache was using libxml2 and the 2.12 branch.

After examining the Apache code (modules/filters/mod_xml2enc.c), it calls htmlParser which is part of libxml2.

Using HTMLParser from python3-lxml (which is libxml2 wrappings for Python), I went through the decoding process of perl-framework/t/htdocs/modules/xml2enc/doc.isohtml which is what is used during the test suite during t/apache/pr64339.t, I was able to determine that libxml2's parser outputs the value observed in teh failing test - namely "<html><body>fóó\n</body></html>" - which indicates this is a libxml2 change.

------

Downstream in Ubuntu, it is simple enough to patch the tests with the attached diff which corresponds to commit 1925450 in upstream test suites.

I looked at the Debian source and the flawed test still exists.  This should be patched in Debian.


Thomas

Index: t/apache/pr64339.t
===================================================================
--- t/apache/pr64339.t (revision 1925449)
+++ t/apache/pr64339.t (revision 1925450)
@@ -18,7 +18,7 @@
     ['/doc.notxml', "application/notreallyxml", "f\xf3\xf3\n" ],

     # Sent with charset=ISO-8859-1 - should be transformed to utf-8
- ['/doc.isohtml', "text/html;charset=utf-8", "<html><body><p>fóó\n</p></body></html>" ],
+ ['/doc.isohtml', "text/html;charset=utf-8", "<html><body>.*fóó\n.*</body></html>" ],
 );

 # mod_xml2enc on trunk behaves quite differently to the 2.4.x version
@@ -42,5 +42,5 @@

     ok t_cmp($r->code, 200, "fetching ".$t->[0]);
     ok t_cmp($r->header('Content-Type'), $t->[1], "content-type header test for ".$t->[0]);
- ok t_cmp($r->content, $t->[2], "content test for ".$t->[0]);
+ ok t_cmp($r->content, qr/$t->[2]/, "content test for ".$t->[0]);
 }

--- End Message ---
--- Begin Message --- 
Source: apache2
Source-Version: 2.4.65-3
Done: Bastien Roucariès <rouca@debian.org>

We believe that the bug you reported is fixed in the latest version of
apache2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1107289@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastien Roucariès <rouca@debian.org> (supplier of updated apache2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 11 Aug 2025 19:07:56 +0200
Source: apache2
Architecture: source
Version: 2.4.65-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Bastien Roucariès <rouca@debian.org>
Closes: 787584 880421 915855 1106280 1107289
Changes:
 apache2 (2.4.65-3) unstable; urgency=medium
 .
   * Change default LANG in envvars from C to C.UTF-8
     (Closes: #787584)
   * systemd service apache2 is aliased to httpd
     (Closes: #915855)
   * document a2* environment files in man page
     (Closes: #880421)
   * Failing test in its test suite
     (Closes: #1107289, LP: #2112429)
   * Restart on-abnormal instead of on-abort
     (Closes: #1106280)
   * Allow triggers to use maintscript helper to restart apache
     (LP: #2038912)
Checksums-Sha1:
 6479383daec42b7b08d2c04246946e36d51d887b 3494 apache2_2.4.65-3.dsc
 7b23159065cdd739bb9f630d8295fae0e8c0b727 9814591 apache2_2.4.65.orig.tar.gz
 c7833822af34679f151b8c8a57d998ba77708bf6 833 apache2_2.4.65.orig.tar.gz.asc
 8308891f438cb7de0723498ad2fb0075b732a435 825764 apache2_2.4.65-3.debian.tar.xz
 adfe4cb925d2c14a41c4b197b34306e63c82e1f6 11998 apache2_2.4.65-3_amd64.buildinfo
Checksums-Sha256:
 245d3ec0a1717ab18946cb1a37182048206e05f199ddbff38e97d103c3dfbfa8 3494 apache2_2.4.65-3.dsc
 4f92861a50325c6d1046ebad5d814bff0d4169ada8cc265655f32b7f1ba4be1b 9814591 apache2_2.4.65.orig.tar.gz
 500de0ea39e041cbbafab9c0e0697b0e0e65b99f29cd1a403741d2afc5383995 833 apache2_2.4.65.orig.tar.gz.asc
 b13dc41a9aa98f59bef20a5979fa6b5937febdb3f50c1f001a93b4b03aec3dd8 825764 apache2_2.4.65-3.debian.tar.xz
 d81c15f6538ab63ca1cd40bc52ff100cf9b5c89962c1ad25c08e73176e1f9e0d 11998 apache2_2.4.65-3_amd64.buildinfo
Files:
 60fea8a57e5394c3d002e6b5bbe3ac6d 3494 httpd optional apache2_2.4.65-3.dsc
 e7bc55dca2ff88a81da208ab50b3f8a7 9814591 httpd optional apache2_2.4.65.orig.tar.gz
 77e7f7bf91a2f3c4c249449409a10ac5 833 httpd optional apache2_2.4.65.orig.tar.gz.asc
 d8ae63988b9e8f356577e69af25e287f 825764 httpd optional apache2_2.4.65-3.debian.tar.xz
 391921148bbbcb4870246c472e7a7f4e 11998 httpd optional apache2_2.4.65-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXQGHuUCiRbrXsPVqADoaLapBCF8FAmiaPgcACgkQADoaLapB
CF+2hA//SHCrRKUK9+EZ1nT7FQ1ggOOvCEF1NYxR76BMq5FjmULcMQAppx6lgwjB
Qh5BjG4+BoDXvxlH9PISsMMdT5VHnICLx7KL6RLHLXJwOHPP/+F1snyeuSeMs+0W
0DtYQklIaWQVVNWRIdircpb6hg15reX5x6UXK8+kEb8wuegxlHb9T4yWXRYFxtVN
tpSSvIoH2nYmg6H1yvL9UIRzG7Wpy2Wz/V/HompnOlXWYQawxAORYZ0yy6VNLYT6
EP759FJE35aL+wdHhm4AVzFmnzAqMsHrCKIBcdx/XnNhM0o+DDWKvrlw/SMfiqKO
mLV4VlDrW3wdv16pOiJSCjMF/zuyCRbi2R2ulKncd5hWhacBG4TOoNTpp06tORnw
Cyosy8PJVlK9RI1jMmXu45d6DMGpXsJsi4IXVy8ICZFOLFFgtC1R+k+FmggJzGIY
bi00RKKsj0cX27ZaTkqwNmUR+qRNt2TSeoyRsgm8qome9DhjU6ehIAgs+MfhVbv7
N9urjV4BWxKZQI9XE1gCXAnWYMN0EOZbw0IOEmGo3OEiaTlxU3ryQogZ+V6pvCbQ
kULEF9OkYpY2OcdIXbLu0w5LOti7So1BXjPkVOGMTaNyRo4mOo0OF62ipo98M6K6
78uLK5jnjTCBrBExyHEWy9+YU2YMTI92HrebOBl8pPflyI3+lBA=
=82qr
-----END PGP SIGNATURE-----

Attachment: pgpvJQccpgA_H.pgp
Description: PGP signature


--- End Message ---
Reply to: