Bug#1017868: ssl-cert: Needless bash dependency

[Stefan Fritsch <sf@sfritsch.de>]

Hi,

Am 21.08.22 um 21:59 schrieb наб:
> The installed make-ssl-cert depends on bash,
> but doesn't really need to.

I am sorry, but I don't see any advantage here in switching away from 
bash. The performance advantage of dash over bash is completely 
irrelevant in make-ssl-cert, and bash is essential: yes.

> See patch based on current Salsa HEAD, below;
> it's shellcheck-clean.
>
> The same could trivially be done for the tests,
> since pretty much the only extension shellcheck picks up is local.

local is not a bash extension. Or what do you mean?

I haven't done a thorough review, but this bit is wrong:

>   
>   ask_via_debconf() {
>       RET=""
> -    if db_settitle make-ssl-cert/title ; then
> -	: # OK
> -    else
> +    if ! db_settitle make-ssl-cert/title ; then
>   	echo "Debconf failed with error code $? $RET" >&2
>   	echo "Maybe your debconf database is corrupt." >&2
>   	echo "Try re-installing ssl-cert." >&2
>       fi

$? will be 0 in the echo and not the return value from debconf.


Cheers,
Stefan