[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#979813: marked as done (apache2.logrotate is crufty)



Your message dated Tue, 08 Jun 2021 07:18:35 +0000
with message-id <E1lqW0R-000HLq-Ng@fasolo.debian.org>
and subject line Bug#979813: fixed in apache2 2.4.48-1
has caused the Debian Bug report #979813,
regarding apache2.logrotate is crufty
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
979813: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979813
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: src:apache2
Version: 2.4.46
Severity: minor
Tags: patch

Debian Apache Maintainers,

apache2.logrotate is crufty, which makes it confusing to modify.

The attached patch does the following:
  1) Moves the prerotate script before the postrotate script
  2) Simplifies check of whether apache2 is running
  3) Removes crufty "> /dev/null", ";", and "\"
  4) Uses consistent four-space indentation

Thank you!
Daniel Lewart
Urbana, Illinois
--- apache2.logrotate.orig	2020-09-01 07:50:51.000000000 -0500
+++ apache2.logrotate	2021-01-11 00:00:00.000000000 -0600
@@ -1,20 +1,20 @@
 /var/log/apache2/*.log {
-	daily
-	missingok
-	rotate 14
-	compress
-	delaycompress
-	notifempty
-	create 640 root adm
-	sharedscripts
-	postrotate
-                if invoke-rc.d apache2 status > /dev/null 2>&1; then \
-                    invoke-rc.d apache2 reload > /dev/null 2>&1; \
-                fi;
-	endscript
-	prerotate
-		if [ -d /etc/logrotate.d/httpd-prerotate ]; then \
-			run-parts /etc/logrotate.d/httpd-prerotate; \
-		fi; \
-	endscript
+    daily
+    missingok
+    rotate 14
+    compress
+    delaycompress
+    notifempty
+    create 640 root adm
+    sharedscripts
+    prerotate
+	if [ -d /etc/logrotate.d/httpd-prerotate ]; then
+	    run-parts /etc/logrotate.d/httpd-prerotate
+	fi
+    endscript
+    postrotate
+	if pgrep -f ^/usr/sbin/apache2 > /dev/null; then
+	    invoke-rc.d apache2 reload
+	fi
+    endscript
 }

--- End Message ---
--- Begin Message ---
Source: apache2
Source-Version: 2.4.48-1
Done: Ondřej Surý <ondrej@debian.org>

We believe that the bug you reported is fixed in the latest version of
apache2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 979813@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ondřej Surý <ondrej@debian.org> (supplier of updated apache2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 08 Jun 2021 08:29:35 +0200
Source: apache2
Architecture: source
Version: 2.4.48-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Ondřej Surý <ondrej@debian.org>
Closes: 979813 985012
Changes:
 apache2 (2.4.48-1) experimental; urgency=medium
 .
   [ Daniel Lewart ]
   * Update apache2.logrotate (Closes: #979813)
 .
   [ Andreas Hasenack ]
   * Avoid test suite failure (Closes: #985012)
 .
   [ Yadd ]
   * Update lintian overrides
   * Re-export upstream signing key without extra signatures.
 .
   [ Ondřej Surý ]
   * New upstream version 2.4.48 (Closes: CVE-2021-31618)
Checksums-Sha1:
 66b828e81008b9096db43347f94a28fa6245dff8 3621 apache2_2.4.48-1.dsc
 b581bcfdd939fe77c3821f7ad3863c7307374919 9418226 apache2_2.4.48.orig.tar.gz
 d6e2530fcb2aa8ef9a696f8692664466c84d2a41 874 apache2_2.4.48.orig.tar.gz.asc
 588fdd2d67a67289deea2674fa838de378556b5e 884076 apache2_2.4.48-1.debian.tar.xz
 1e1d99483d0482050a0076141da5b9512efba352 12250 apache2_2.4.48-1_amd64.buildinfo
Checksums-Sha256:
 fbd0465fc6e94cf2969977c84bb554e1fbdf79e90565af68d704a5a06a96c438 3621 apache2_2.4.48-1.dsc
 315c0bc50206b866fb17c2cdc28c1973765a8d59ca168b80286e8cb077d0510e 9418226 apache2_2.4.48.orig.tar.gz
 fd5b3e06eb7029c6e38bb891faa9dc6e17079cde191a07e605800258a9373f03 874 apache2_2.4.48.orig.tar.gz.asc
 56862991c2734c73ebbc4e3a3e9345499daa1c16a802fe2ed7f1203615b60fb1 884076 apache2_2.4.48-1.debian.tar.xz
 837512129f36a505e9aa7a7faa8b71c1baf4fe177ef3a9c02ebafba8254fe27f 12250 apache2_2.4.48-1_amd64.buildinfo
Files:
 ba4fceb153d33aeaac7e0283ac47bad2 3621 httpd optional apache2_2.4.48-1.dsc
 033453c49c4b081e34acc3e1a4c23648 9418226 httpd optional apache2_2.4.48.orig.tar.gz
 ede92e64f6bba88a74211fd45628ef4b 874 httpd optional apache2_2.4.48.orig.tar.gz.asc
 ab7192e881afa355827024b8968f5d58 884076 httpd optional apache2_2.4.48-1.debian.tar.xz
 e4ff5f1398ff81deb072973081116dba 12250 httpd optional apache2_2.4.48-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAmC/FPBfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcJrlxAAj8jVQiSWxcI6knLkbaMTGQ4FgLEKlLPmDG+TgEr7cFsO/EXSJ407rpIh
tnN+hFU9iTa0T4M4Pgh+seg2K6z0WyY/yaal0+2DxqghJjh3IhvUayq5YLlJ1ryK
goNSQKDm0dEqK2tmjXM3TV24uk0nZwnYL25BYgbzFfN1qO0tsqxo0sbrMmBtcBBw
9UgdGtoUZRDslqD7cYdoapR+xhqNPtVAB0UARhEbjApD8Ce5fjPV7yH5OclGncOU
PkMN5eJ235adZBOPr2qsl9cAsOU8gNjncL5PRAH3z6dC961gsiaOH+LhqVv285QP
DM7eOO3CQl7kQ/2r0bSgU9iT531gvPYNi7et+AK2pZ1xLCQ7BZ40eDwA5LWOth3O
fgPF4iXtikc+M/TW5wWRrszCk+YE15eVBkF/D3sqSORS26Z7t9Rcp7hvUw2oyT36
cXyYONzijjHWtyIMgsMlGgckGDYcjeNdWpGS0xdyvEQ0IcQp+LcnF6YIG8/6h4yd
aFGu5I4bLm7t5JKNBOkAQ/i+4F2elz7i4S/d/tzWMyYCSXAFdpkEByJn54I3YlA1
MWUxySS/TwBDVowlbMEh7RYiHlZjAzp4D4rSTq9qCRUvs2uuhuIuppkH00m3wXvb
+6npdGqZvNdw9EU9qb1tnAfdROXGuwu/BoilsGTFb2mnqoqtUGM=
=6HYH
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: