[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988310: ssl-cert: make-ssl-cert uses same filename for template and output



On Sun, 6 Jun 2021 21:55:14 +0200 Stefan Fritsch <sf@sfritsch.de> wrote:
I won't be able to deal with this for at least 1-2 weeks. It would be nice if someone could look at it and downgrade or NMU+unblock.
Consider it done :)

The suggested patch shifts the arguments, like it is done on other parts of the
script.
After looking at the script, I think it's better to replace the
output="${1}" with output="${2}" instead, because shift will have a
non-zero exit code and terminate the script (bash -e) without
notice. In particular, the user will not get the usage message which
tells him that he has to pass *two* arguments.

I'll prepare an NMU and upload it shortly.

Cheers
Timo

--
⢀⣴⠾⠻⢶⣦⠀   ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁   │ Timo Röhling                                       │
⢿⡄⠘⠷⠚⠋⠀   │ 9B03 EBB9 8300 DF97 C2B1  23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀   ╰────────────────────────────────────────────────────╯

Attachment: signature.asc
Description: PGP signature


Reply to: