[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890108: marked as done (apr-util: FTBFS with debhelper/11.1 due to empty build target)

Your message dated Sun, 25 Feb 2018 12:04:48 +0000
with message-id <E1epv2u-000HjG-13@fasolo.debian.org>
and subject line Bug#890108: fixed in apr-util 1.6.1-2
has caused the Debian Bug report #890108,
regarding apr-util: FTBFS with debhelper/11.1 due to empty build target
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
890108: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890108
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: apr-util
Version: 1.6.1-1
Severity: serious
Tags: patch

Hi,

The apr-util package FTBFS with debhelper/11.1 as it has an empty
build target.  This is caused by debhelper had a bug in its handling
of "explicitly defined rules targets" that has now been fixed.

Previously, this happened to work because dpkg-buildpackage would
invoke "debian/rules build" (which would be a no-op) followed by
"fakeroot debian/rules binary".  During the binary target, dh's
suboptimal handling would run the build commands.


The solution is trivial but less pretty; explicitly define "build"
with the same content as the "%:" target (or rename the "build" folder
and drop the ".PHONY" target).  I have attached a patch for this.

I have also added two optional patches (0002 + 0003) to remove some
redundancy by reducing the number of options passed to dh.  When
apr-util in unstable was rebuilt, they produced bit-for-bit identical
output compared to apr-util in sid (with 0001; I could not built it
without 0001, which is why I am filing the bug).
  Both patches bumps the minimum debhelper version requriement for
building apr-util.  Most likely, it will be a non-issue for you as the
minimum requirements are satisfied in stable and oldstable-backports.


Unfortunately, even after fixing this bug, apr-util FTBFS due to a
test failure[1].  I verified that this test failure also occurs when
building with debhelper/11 and is therefore unrelated to this issue.
However, it meant that all of my builds had to be done with
DEB_BUILD_OPTIONS=nocheck.  I also noted a warning that is probably
unrelated to this test failure but may cause issues as well[2].


More details can be found in:
 * #886901 comment #35
 * #887688 comment #37
 * #880840

Apologies for the inconvenience.

Thanks,
~Niels

[1] testdbm             : -Line 155: expected <0>, but saw <20014>
FAILED 1 of 3

[2]:
<BUILDDIR>/dbd/apr_dbd_mysql.c: In function 'dbd_mysql_init':
<BUILDDIR>/dbd/apr_dbd_mysql.c:1265:5: warning: implicit declaration of function 'my_init'; did you mean 'mysql_init'? [-Wimplicit-func]
     my_init();
     ^~~~~~~
     mysql_init

>From 5ec6f1fd0419eb65785b610bea4be166dd6c7d24 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Sun, 11 Feb 2018 09:51:23 +0000
Subject: [PATCH 1/3] Avoid empty build target

The dh sequencer as of debhelper/11.1 is stricter with this in order
to solve #880840 (where debhelper would fail to handle such targets
correctly).

Signed-off-by: Niels Thykier <niels@thykier.net>
---
 debian/rules | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/debian/rules b/debian/rules
index 871244c..386921a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -22,6 +22,11 @@ DB_VERSION = $(shell dpkg-query -W -f '$${Version}' libdb-dev | \
 # The 'build' target needs special handling because there there is a directory
 # named 'build'.
 .PHONY: build
+# The build target must not be empty.  Sadly because of how make
+# works, we have do duplicate the target in this case.
+build:
+	dh $@ -B$(BUILDDIR) --parallel --with autotools_dev
+
 %:
 	dh $@ -B$(BUILDDIR) --parallel --with autotools_dev
 
-- 
2.15.1


>From 127bf9c0d541a535b24198f07b4157f4a49c4aa3 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Sun, 11 Feb 2018 10:00:46 +0000
Subject: [PATCH 2/3] Drop deprecated autotools-dev sequence

Signed-off-by: Niels Thykier <niels@thykier.net>
---
 debian/control | 2 +-
 debian/rules   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index ce88602..523f365 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: libs
 Priority: optional
 Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
 Uploaders: Stefan Fritsch <sf@debian.org>
-Build-Depends: debhelper (>> 9~), autoconf, autotools-dev, mawk, libldap2-dev, libexpat1-dev, libdb-dev, libgdbm-dev, libpcre3-dev, libapr1-dev (>> 1.4.8-2~), libsqlite3-dev, libpq-dev, python:any, default-libmysqlclient-dev, unixodbc-dev, doxygen, libssl-dev
+Build-Depends: debhelper (>> 9~), autoconf, mawk, libldap2-dev, libexpat1-dev, libdb-dev, libgdbm-dev, libpcre3-dev, libapr1-dev (>> 1.4.8-2~), libsqlite3-dev, libpq-dev, python:any, default-libmysqlclient-dev, unixodbc-dev, doxygen, libssl-dev
 Standards-Version: 4.0.1
 Vcs-Browser: https://anonscm.debian.org/cgit/pkg-apache/apr-util.git
 Vcs-Git: git://anonscm.debian.org/pkg-apache/apr-util.git
diff --git a/debian/rules b/debian/rules
index 386921a..59690ae 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,10 +25,10 @@ DB_VERSION = $(shell dpkg-query -W -f '$${Version}' libdb-dev | \
 # The build target must not be empty.  Sadly because of how make
 # works, we have do duplicate the target in this case.
 build:
-	dh $@ -B$(BUILDDIR) --parallel --with autotools_dev
+	dh $@ -B$(BUILDDIR) --parallel
 
 %:
-	dh $@ -B$(BUILDDIR) --parallel --with autotools_dev
+	dh $@ -B$(BUILDDIR) --parallel
 
 #
 # configure
-- 
2.15.1


>From 1517378c668a2153ba9ab8f6389175eba3990d8c Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Sun, 11 Feb 2018 10:09:30 +0000
Subject: [PATCH 3/3] Bump debhelper compat to 10

This enables us to ditch the --parallel option for dh as it is now the
default.

Signed-off-by: Niels Thykier <niels@thykier.net>
---
 debian/compat  | 2 +-
 debian/control | 2 +-
 debian/rules   | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian/compat b/debian/compat
index ec63514..f599e28 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+10
diff --git a/debian/control b/debian/control
index 523f365..ba4e470 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: libs
 Priority: optional
 Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
 Uploaders: Stefan Fritsch <sf@debian.org>
-Build-Depends: debhelper (>> 9~), autoconf, mawk, libldap2-dev, libexpat1-dev, libdb-dev, libgdbm-dev, libpcre3-dev, libapr1-dev (>> 1.4.8-2~), libsqlite3-dev, libpq-dev, python:any, default-libmysqlclient-dev, unixodbc-dev, doxygen, libssl-dev
+Build-Depends: debhelper (>> 10~), autoconf, mawk, libldap2-dev, libexpat1-dev, libdb-dev, libgdbm-dev, libpcre3-dev, libapr1-dev (>> 1.4.8-2~), libsqlite3-dev, libpq-dev, python:any, default-libmysqlclient-dev, unixodbc-dev, doxygen, libssl-dev
 Standards-Version: 4.0.1
 Vcs-Browser: https://anonscm.debian.org/cgit/pkg-apache/apr-util.git
 Vcs-Git: git://anonscm.debian.org/pkg-apache/apr-util.git
diff --git a/debian/rules b/debian/rules
index 59690ae..49e870c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,10 +25,10 @@ DB_VERSION = $(shell dpkg-query -W -f '$${Version}' libdb-dev | \
 # The build target must not be empty.  Sadly because of how make
 # works, we have do duplicate the target in this case.
 build:
-	dh $@ -B$(BUILDDIR) --parallel
+	dh $@ -B$(BUILDDIR)
 
 %:
-	dh $@ -B$(BUILDDIR) --parallel
+	dh $@ -B$(BUILDDIR)
 
 #
 # configure
-- 
2.15.1

--- End Message ---
--- Begin Message --- 
Source: apr-util
Source-Version: 1.6.1-2

We believe that the bug you reported is fixed in the latest version of
apr-util, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 890108@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stefan Fritsch <sf@debian.org> (supplier of updated apr-util package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 25 Feb 2018 12:40:36 +0100
Source: apr-util
Binary: libaprutil1 libaprutil1-ldap libaprutil1-dbd-mysql libaprutil1-dbd-sqlite3 libaprutil1-dbd-odbc libaprutil1-dbd-pgsql libaprutil1-dev libaprutil1-dbg
Architecture: source amd64
Version: 1.6.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Stefan Fritsch <sf@debian.org>
Description:
 libaprutil1 - Apache Portable Runtime Utility Library
 libaprutil1-dbd-mysql - Apache Portable Runtime Utility Library - MySQL Driver
 libaprutil1-dbd-odbc - Apache Portable Runtime Utility Library - ODBC Driver
 libaprutil1-dbd-pgsql - Apache Portable Runtime Utility Library - PostgreSQL Driver
 libaprutil1-dbd-sqlite3 - Apache Portable Runtime Utility Library - SQLite3 Driver
 libaprutil1-dbg - Apache Portable Runtime Utility Library - Debugging Symbols
 libaprutil1-dev - Apache Portable Runtime Utility Library - Development Headers
 libaprutil1-ldap - Apache Portable Runtime Utility Library - LDAP Driver
Closes: 889170 890108
Changes:
 apr-util (1.6.1-2) unstable; urgency=medium
 .
   * Avoid empty build target, fixes FTBFS. Thanks to Niels Thykier for the
     patch. Closes: #890108
   * Fix handling of gdbm_errno in gdbm driver. Closes: #889170
   * Bump debhelper compat level to 11 and drop deprecated autotools-dev
     sequence. Thanks to Niels Thykier for the patch.
   * Bump Standards-Version (no changes)
   * Fix mysql/mariadb header detection, broken since 1.5.3-3.
   * Include NOTICE file in packages, as required by license.
Checksums-Sha1:
 350e598d1274496c6f8e834e7c119a154b52c351 2851 apr-util_1.6.1-2.dsc
 90bc0d57372e6062e066a212d53009f83a96676b 211832 apr-util_1.6.1-2.debian.tar.xz
 79605f63e39607512903ae5c6c7f161d01782905 9688 apr-util_1.6.1-2_amd64.buildinfo
 07b14729399bab545d6d4869cd8c509ba62f688b 20760 libaprutil1-dbd-mysql_1.6.1-2_amd64.deb
 210c6f8ea1692cf17bf724f1d16623742803236b 24376 libaprutil1-dbd-odbc_1.6.1-2_amd64.deb
 a640ac79866565da6fb5428384e3aba5c84382c6 20644 libaprutil1-dbd-pgsql_1.6.1-2_amd64.deb
 5a9078f28d822815afd48c4403fe0ec86c2478cf 18688 libaprutil1-dbd-sqlite3_1.6.1-2_amd64.deb
 4a2793820749c16a5da16f1ace01835e7978700c 352988 libaprutil1-dbg_1.6.1-2_amd64.deb
 e791ac47dd0eafcec1d36bb254d71664e26e4e47 403740 libaprutil1-dev_1.6.1-2_amd64.deb
 bbe4372c76a4a5558de46542e5fa8d070ce8fc8b 16804 libaprutil1-ldap_1.6.1-2_amd64.deb
 9dad898af352ef9daa083d5cdcbde5d19ced84d4 91812 libaprutil1_1.6.1-2_amd64.deb
Checksums-Sha256:
 7a3a7d0dccc0d89ad751988163cb57d34b32094893d08c4d0ac79e9bfee6d8f4 2851 apr-util_1.6.1-2.dsc
 e30e919e7e049a8a7056b7184e77d69b82660d71a4bf9654d1c9bfccf2fcde30 211832 apr-util_1.6.1-2.debian.tar.xz
 d02a4b4e28285349774fb8b3491a6a6ad94c28cc38bc61173199e9c6d4733453 9688 apr-util_1.6.1-2_amd64.buildinfo
 7c91a8e0b822aae6d666981edc064596895d0ecfafce753d549e32c77875cc39 20760 libaprutil1-dbd-mysql_1.6.1-2_amd64.deb
 48634b2adbfca19daddabe82874f74e0cbf2d7f6e5c50249ed9b9bb5057b99f8 24376 libaprutil1-dbd-odbc_1.6.1-2_amd64.deb
 bf2ea348275c4d5bc4a091ad8955e7c8cd27a051f0506eda2867b32e09e4e076 20644 libaprutil1-dbd-pgsql_1.6.1-2_amd64.deb
 297f6196855ff9eac854dc20d79aa3ca10c77a18e5a0eedb0d72e0ebb21743e0 18688 libaprutil1-dbd-sqlite3_1.6.1-2_amd64.deb
 96db596ff4197ea88a52f5fbe997185a59a738fbf785e7643a91ab64d13f527c 352988 libaprutil1-dbg_1.6.1-2_amd64.deb
 21ff3b2f4a871d3e44a3c9f4469d6814d098d97e2a2f39ffd5e5f79d02a6a1ca 403740 libaprutil1-dev_1.6.1-2_amd64.deb
 446a67107a5d745a7b9528f0ce7c368602c37db9304ab6acc72df8599b599267 16804 libaprutil1-ldap_1.6.1-2_amd64.deb
 1facd960e97704840afdb11f66cd78eaad8eb6314c90e56abdc8815911f72184 91812 libaprutil1_1.6.1-2_amd64.deb
Files:
 f99e6b5a25e2a8131b919c7ebd57140d 2851 libs optional apr-util_1.6.1-2.dsc
 329b096f2df85d6031970829e9e84a07 211832 libs optional apr-util_1.6.1-2.debian.tar.xz
 78a60d22816b64395e95d25bc3bb6fcf 9688 libs optional apr-util_1.6.1-2_amd64.buildinfo
 7502ac823cdbb13fed261804790017ef 20760 libs optional libaprutil1-dbd-mysql_1.6.1-2_amd64.deb
 95ebdf6c06d8dd1077b5031da212ff9b 24376 libs optional libaprutil1-dbd-odbc_1.6.1-2_amd64.deb
 f51c8935b8ac920e62242252cbb6e8a5 20644 libs optional libaprutil1-dbd-pgsql_1.6.1-2_amd64.deb
 6776d5a46bc0fda88a3eaf0bc2f7175b 18688 libs optional libaprutil1-dbd-sqlite3_1.6.1-2_amd64.deb
 61e524bc01c1ce132ca205749a2a9653 352988 debug optional libaprutil1-dbg_1.6.1-2_amd64.deb
 3e2c4f53166d24b4fac10c4b89a90f74 403740 libdevel optional libaprutil1-dev_1.6.1-2_amd64.deb
 d50cd5b9dbc2446001a3a091ce778fa4 16804 libs optional libaprutil1-ldap_1.6.1-2_amd64.deb
 e4d6e6dfb8c430a12edc685cef4160cb 91812 libs optional libaprutil1_1.6.1-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOpiNza8JqByyYYsxxodfNUHO/eAFAlqSog0ACgkQxodfNUHO
/eBCPQ/9G19t7u2PVgBJMMBbnksy8T1Yu0TkuN9q4iNsJdxwjIyuvN+18kZfBcrT
vll2jyBPsaGL9W/Z27NMK7qHSbldweM6HZ701YJ0MQTrBsdEDhM96Abj3XZWACmR
MhA4SqxAbmfqcLMidOib5CpZWGYf/uyIh/FF9vlTRac1501jNl3/DnPR9FN+GIN/
/uJjPKYPPRAK7Qz2JzFCtIEzRrosCzi41qEqSgFINkCGMvD18L15/FqTqcGLpPqx
z4wuAixpjR1Zjixy7CJvrMzZ2QPRZUvN08DW8ST4aJPru9NkFLZ2UrklcQKgJisE
7Q4z5DBmkPqs9k0sUZHrMVYqHnEtijRxbSn81ENIHhrSqt4v5i0AIKrpncB0rSEo
XShtg8LcflSwNUcuHOydepOBYFLukVQhnGcT1zGWzLZdytVFYAKk+Ch0KxN7bzfI
f7XfZziEhIfO4heWAeffoE3JnHKtJMixoYS8B5YjztWk2lt1CUJgfVgXkRG+3Sej
6psYLQk1oM//VtuyuctCqpReiDoYSe0ZS3jaMzWq5fd3XFAWlSiZrrkvgzGw7C/7
ulRfCsx4UO/5rmexluw/eaPHDa39EgCyj/Op/+ekCl7gSwuFJYB1OOS3adOuPayD
H+g2lFCktFhGMyXBG8rU4AK9TSAr7jAerk7z8iloJyr9zqvtKoM=
=EPt0
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: