[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#720414: apache2-dev: invoking apache2-maintscript-helper should be protected with -r, not -e



On Sun, Sep 28, 2014 at 02:18:59PM +0200, Stefan Fritsch wrote:
> On Wednesday 21 August 2013 15:43:49, Julian Gilbey wrote:
> 
> > The example maintainer script fragment in
> > /usr/share/doc/apache2/PACKAGING.gz and the dh_apache2 script
> > protect the call to source the apache2-maintscript-helper shell
> > script with a [ -e ... ] (file exists); better would be [ -r ... ]
> > (file is readable).
> 
> I disagree. If the helper exists but is not readable, something is 
> wrong. In this case it is better to exit with an error than silently 
> not executing the relevant code.
> 
> Therefore I am closing this bug.

OK, good point.

   Julian


Reply to: