Bug#714083: apache2.2-common: a2enmod does not prefix 000- to default-ssl site

[Matt Perry <popmusik79@gmail.com>]

Package: apache2.2-common
Version: 2.2.22-13
Severity: minor
Tags: patch

Dear Maintainer,

a2ensite and a2dissite will prefix 000- to the default site so that it's always
first in the Apache config. However, default-ssl is not afforded the same
treatment.

Since Apache supports SNI, it's important to have the default-ssl config be
first so it will respond to SSL requests when a site name is invalid or doesn't
match a named virtual host. This will make the behavior for SSL sites be the
same as for non-SSL sites.

I've supplied a patch for a2enmod below.




-- Package-specific info:
List of enabled modules from 'apache2 -M':
  alias auth_basic authn_file authz_default authz_groupfile
  authz_host authz_user autoindex cgi deflate dir env mime
  negotiation php5 reqtimeout setenvif status
List of enabled php5 extensions:
  pdo

-- System Information:
Debian Release: 7.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages apache2.2-common depends on:
ii  apache2-utils  2.2.22-13
ii  apache2.2-bin  2.2.22-13
ii  lsb-base       4.1+Debian8+deb7u1
ii  mime-support   3.52-1
ii  perl           5.14.2-21
ii  procps         1:3.3.3-3

Versions of packages apache2.2-common recommends:
ii  ssl-cert  1.0.32

Versions of packages apache2.2-common suggests:
pn  apache2-doc                             <none>
pn  apache2-suexec | apache2-suexec-custom  <none>
ii  iceweasel [www-browser]                 17.0.6esr-1~deb7u1
ii  w3m [www-browser]                       0.5.3-8

Versions of packages apache2.2-common is related to:
pn  apache2-mpm-event    <none>
pn  apache2-mpm-itk      <none>
ii  apache2-mpm-prefork  2.2.22-13
pn  apache2-mpm-worker   <none>

-- no debconf information

*** /home/testuser/a2enmod.patch
--- a2enmod.orig        2013-03-04 13:00:37.000000000 -0800
+++ a2enmod     2013-06-25 06:30:12.781913065 -0700
@@ -98,6 +98,7 @@
         s{^$choicedir/}{};
         s{$sffx$}{};
         s{^000-default$}{default};
+        s{^000-default-ssl$}{default-ssl};
         $_
     } glob("$choicedir/$arg$sffx");

@@ -112,7 +113,7 @@
     my $acton = shift;

     my $prio = "";
-    if ( $obj eq 'site' && $acton eq 'default' ) {
+    if ( $obj eq 'site' && ($acton eq 'default' || $acton eq 'default-ssl') )
{
         $prio = '000-';