[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#703466: marked as done (apr: builds without $CFLAGS, only with $H_CFLAGS)

Your message dated Sat, 06 Jul 2013 21:47:09 +0000
with message-id <E1UvaJx-00011z-39@franck.debian.org>
and subject line Bug#703466: fixed in apr 1.4.6-3+deb7u1
has caused the Debian Bug report #703466,
regarding apr: builds without $CFLAGS, only with $H_CFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
703466: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703466
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: apr
Version: 1.4.6-3
Severity: important
Tags: patch

d/rules currently passes CFLAGS and LDFLAGS to configure. However,
the invocation of make overrides CFLAGS and LDFLAGS with H_FLAGS and
H_LDFLAGS, thus only $H_FLAGS and $H_LDFLAGS are used to compile apr.
$CFLAGS and $LDFLAGS are ignored. Consequently, apr is built without
-O2 and -g.

The attached patch uses both ${C,LD}FLAGS and $H_{C,LD}FLAGS to build
the package.

Regards
-- 
Sebastian Ramacher

diff -Nru apr-1.4.6/debian/rules apr-1.4.6/debian/rules
--- apr-1.4.6/debian/rules	2012-05-19 16:06:37.000000000 +0200
+++ apr-1.4.6/debian/rules	2013-03-20 00:21:08.000000000 +0100
@@ -68,7 +68,7 @@
 	# we need to force the use of bash here. Otherwise, if apr is built with
 	# /bin/sh -> /bin/bash, the resulting libtool will not work on systems
 	# where /bin/sh -> /bin/dash
-	cd $(BUILDDIR) && CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" $(CONFFLAGS) CONFIG_SHELL=/bin/bash /bin/bash ../configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --enable-layout=Debian --includedir=\$${prefix}/usr/include/apr-1.0 --with-installbuilddir=\$${prefix}/usr/share/apr-1.0/build  --enable-nonportable-atomics --enable-allocator-uses-mmap
+	cd $(BUILDDIR) && CFLAGS="$(CFLAGS) $(H_CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS) $(H_LDFLAGS)" $(CONFFLAGS) CONFIG_SHELL=/bin/bash /bin/bash ../configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --enable-layout=Debian --includedir=\$${prefix}/usr/include/apr-1.0 --with-installbuilddir=\$${prefix}/usr/share/apr-1.0/build  --enable-nonportable-atomics --enable-allocator-uses-mmap
 	# Determine whether upstream's configure gives the same definition of apr_ino_t as we had until 1.2.11-1
 	rm -f debian/ino_t_test
 	gcc -I$(CURDIR)/include -I$(BUILDDIR)/include `$(BUILDDIR)/apr-1-config --cppflags` -o debian/ino_t_test debian/ino_t_test.c
@@ -100,7 +100,7 @@
 build-stamp: $(BUILDDIR)/config.status
 	dh_testdir
 
-	$(MAKE) -C $(BUILDDIR) CFLAGS="$(H_CFLAGS)" LDFLAGS="$(H_LDFLAGS)"
+	$(MAKE) -C $(BUILDDIR)
 	$(MAKE) -C $(BUILDDIR) dox
 
 	touch $@
@@ -125,7 +125,7 @@
 
 test-stamp: build
 	dh_testdir
-	$(MAKE) -C $(BUILDDIR)/test all CFLAGS="$(H_CFLAGS)" LDFLAGS="$(H_LDFLAGS)"
+	$(MAKE) -C $(BUILDDIR)/test all
 	cd $(BUILDDIR)/test && ./testall -v testsockets testsock || $(IGNORE_TESTSOCK)
 	cd $(BUILDDIR)/test && ( ulimit -S -s 8192 ; ./testall -v testatomic)
 	cd $(BUILDDIR)/test && ./testall -v -x testsockets testsock testatomic

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: apr
Source-Version: 1.4.6-3+deb7u1

We believe that the bug you reported is fixed in the latest version of
apr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 703466@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stefan Fritsch <sf@debian.org> (supplier of updated apr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 03 Jul 2013 11:33:06 +0200
Source: apr
Binary: libapr1 libapr1-dev libapr1-dbg
Architecture: source i386
Version: 1.4.6-3+deb7u1
Distribution: stable
Urgency: low
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Stefan Fritsch <sf@debian.org>
Description: 
 libapr1    - Apache Portable Runtime Library
 libapr1-dbg - Apache Portable Runtime Library - Debugging Symbols
 libapr1-dev - Apache Portable Runtime Library - Development Headers
Closes: 703466
Changes: 
 apr (1.4.6-3+deb7u1) stable; urgency=low
 .
   * Don't override CFLAGS and LDFLAGS during build. This fixes the debug
     information being useless. Closes: #703466
Checksums-Sha1: 
 bdc8d040c4f7362834b7f74bfa1bf92f2696665f 1444 apr_1.4.6-3+deb7u1.dsc
 041421c0ef294ef919079646ef384600a96e53d8 23012 apr_1.4.6-3+deb7u1.debian.tar.gz
 477d894c0e54aca92602515e5a5b6006528ce729 111880 libapr1_1.4.6-3+deb7u1_i386.deb
 907b42a6ccfe4b6805d9d81e9d41bbcec9e75d55 1122732 libapr1-dev_1.4.6-3+deb7u1_i386.deb
 165cf1bfde68643944e344897d5c05930b7f0a81 228952 libapr1-dbg_1.4.6-3+deb7u1_i386.deb
Checksums-Sha256: 
 ef08770ea2f74d80f4ae3d1113f9d8949d75bf04d5ce65522e86b21325d04351 1444 apr_1.4.6-3+deb7u1.dsc
 1ae4c9435ed6a305a54fc07c368f17e6214820c6da47d3a7f39d25ca3da9dde9 23012 apr_1.4.6-3+deb7u1.debian.tar.gz
 86747169cddc3e91f862ca1deda8bdaa4d8699d787a12b92a73e94e762119eca 111880 libapr1_1.4.6-3+deb7u1_i386.deb
 0cb366894a9296c1ed2490f2d4b925d8ad0e29c3874a104ec4b41c8889b0d7fc 1122732 libapr1-dev_1.4.6-3+deb7u1_i386.deb
 263c0b7a7ce6efbff30c3f61eba539f1621a76a874359b8943bdbea62ba12761 228952 libapr1-dbg_1.4.6-3+deb7u1_i386.deb
Files: 
 79aebe421bea693e9a08207400395179 1444 libs optional apr_1.4.6-3+deb7u1.dsc
 70da63f08b9ec1bc5bde0b7259fea800 23012 libs optional apr_1.4.6-3+deb7u1.debian.tar.gz
 69622aaea27b8a32cefe124a6d56f8f8 111880 libs optional libapr1_1.4.6-3+deb7u1_i386.deb
 67ce6365f7c13f63dd8851a370943424 1122732 libdevel optional libapr1-dev_1.4.6-3+deb7u1_i386.deb
 90df44b93d70df8de2b95109f7967b7f 228952 debug extra libapr1-dbg_1.4.6-3+deb7u1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFR1d/mbxelr8HyTqQRAs8JAKDaWsa1jCvdOfxNjcoXgj8sH5eusACfYUQZ
e7tLQWOiAHwyT0PaG/cbIFI=
=VBl0
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: