[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#703466: marked as done (apr: builds without $CFLAGS, only with $H_CFLAGS)

Your message dated Sat, 11 May 2013 13:32:46 +0000
with message-id <E1Ub9uo-0005gj-Tl@franck.debian.org>
and subject line Bug#703466: fixed in apr 1.4.6-4
has caused the Debian Bug report #703466,
regarding apr: builds without $CFLAGS, only with $H_CFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

703466: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703466
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: apr
Version: 1.4.6-3
Severity: important
Tags: patch

d/rules currently passes CFLAGS and LDFLAGS to configure. However,
the invocation of make overrides CFLAGS and LDFLAGS with H_FLAGS and
H_LDFLAGS, thus only $H_FLAGS and $H_LDFLAGS are used to compile apr.
$CFLAGS and $LDFLAGS are ignored. Consequently, apr is built without
-O2 and -g.

The attached patch uses both ${C,LD}FLAGS and $H_{C,LD}FLAGS to build
the package.

Sebastian Ramacher
diff -Nru apr-1.4.6/debian/rules apr-1.4.6/debian/rules
--- apr-1.4.6/debian/rules	2012-05-19 16:06:37.000000000 +0200
+++ apr-1.4.6/debian/rules	2013-03-20 00:21:08.000000000 +0100
@@ -68,7 +68,7 @@
 	# we need to force the use of bash here. Otherwise, if apr is built with
 	# /bin/sh -> /bin/bash, the resulting libtool will not work on systems
 	# where /bin/sh -> /bin/dash
-	cd $(BUILDDIR) && CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" $(CONFFLAGS) CONFIG_SHELL=/bin/bash /bin/bash ../configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --enable-layout=Debian --includedir=\$${prefix}/usr/include/apr-1.0 --with-installbuilddir=\$${prefix}/usr/share/apr-1.0/build  --enable-nonportable-atomics --enable-allocator-uses-mmap
+	cd $(BUILDDIR) && CFLAGS="$(CFLAGS) $(H_CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS) $(H_LDFLAGS)" $(CONFFLAGS) CONFIG_SHELL=/bin/bash /bin/bash ../configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --enable-layout=Debian --includedir=\$${prefix}/usr/include/apr-1.0 --with-installbuilddir=\$${prefix}/usr/share/apr-1.0/build  --enable-nonportable-atomics --enable-allocator-uses-mmap
 	# Determine whether upstream's configure gives the same definition of apr_ino_t as we had until 1.2.11-1
 	rm -f debian/ino_t_test
 	gcc -I$(CURDIR)/include -I$(BUILDDIR)/include `$(BUILDDIR)/apr-1-config --cppflags` -o debian/ino_t_test debian/ino_t_test.c
@@ -100,7 +100,7 @@
 build-stamp: $(BUILDDIR)/config.status
 	$(MAKE) -C $(BUILDDIR) dox
 	touch $@
@@ -125,7 +125,7 @@
 test-stamp: build
+	$(MAKE) -C $(BUILDDIR)/test all
 	cd $(BUILDDIR)/test && ./testall -v testsockets testsock || $(IGNORE_TESTSOCK)
 	cd $(BUILDDIR)/test && ( ulimit -S -s 8192 ; ./testall -v testatomic)
 	cd $(BUILDDIR)/test && ./testall -v -x testsockets testsock testatomic

Attachment: signature.asc
Description: Digital signature

--- End Message ---
--- Begin Message ---
Source: apr
Source-Version: 1.4.6-4

We believe that the bug you reported is fixed in the latest version of
apr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 703466@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Stefan Fritsch <sf@debian.org> (supplier of updated apr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Sat, 11 May 2013 15:06:24 +0200
Source: apr
Binary: libapr1 libapr1-dev libapr1-dbg
Architecture: source i386
Version: 1.4.6-4
Distribution: unstable
Urgency: low
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Stefan Fritsch <sf@debian.org>
 libapr1    - Apache Portable Runtime Library
 libapr1-dbg - Apache Portable Runtime Library - Debugging Symbols
 libapr1-dev - Apache Portable Runtime Library - Development Headers
Closes: 701193 703466
 apr (1.4.6-4) unstable; urgency=low
   * Make the /dev/shm sanity check during build work if it is a symbolic link.
   * Remove the ancient ino_t configure sanity test that causes a FTBFS on x32.
     Closes: #701193
   * Don't override CFLAGS and LDFLAGS during build. This fixes the debug
     information being useless. Closes: #703466
 b4f10a473e388878853f19d01fcfb00722cac3fa 1416 apr_1.4.6-4.dsc
 22d39b8e52c6ca614a8dd5fb5ffd8943409c3812 22697 apr_1.4.6-4.debian.tar.gz
 3da72a4d856b513bac63067458574a257a39f6e0 110160 libapr1_1.4.6-4_i386.deb
 c99600bc5b3d6690bf0ed49b773c53404aeef070 1122490 libapr1-dev_1.4.6-4_i386.deb
 1c359a878ab4589eb94b3f031ab643f43bc44370 230318 libapr1-dbg_1.4.6-4_i386.deb
 c452f0631b8d5087d54de3d43bef618e7c1888a310d7399515a74d6727cd7c30 1416 apr_1.4.6-4.dsc
 35b25ae3bf1d24745b87878f7f9e7c54c1e3dd8e97d9cd887a38535616c888b0 22697 apr_1.4.6-4.debian.tar.gz
 4d984d61ef5d669346012a8ea56b1ce1c3650cb432f6527709dd8a7d1290502f 110160 libapr1_1.4.6-4_i386.deb
 f57fbfbb1d6299e9e70871a14fb20102488e764d7792b7cd3be61e764a36ea58 1122490 libapr1-dev_1.4.6-4_i386.deb
 5805b943748fa2aa1b1cf96b1c887a99c7959c5c354cd40e4c66a28218d682e2 230318 libapr1-dbg_1.4.6-4_i386.deb
 2bc31b8a886bd60d986de4784d61b671 1416 libs optional apr_1.4.6-4.dsc
 ae8b7eac7e8d8174be836b81808e59a8 22697 libs optional apr_1.4.6-4.debian.tar.gz
 c5f9c6635ccd22048f19c2afe7ed7a2b 110160 libs optional libapr1_1.4.6-4_i386.deb
 f581eb9ebf4dc363d97d3b6ace1dadd3 1122490 libdevel optional libapr1-dev_1.4.6-4_i386.deb
 37f3608ad3b068b8613dce3732bea721 230318 debug extra libapr1-dbg_1.4.6-4_i386.deb

Version: GnuPG v1.4.12 (GNU/Linux)


--- End Message ---

Reply to: