[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#359217: marked as done (exit statement and test logic in init.d/apache2)



Your message dated Wed, 24 Mar 2010 20:30:39 +0000 (WET)
with message-id <20100324203039.7E020311C@kmos.homeip.net>
and subject line Package apache-common has been removed from Debian
has caused the Debian Bug report #359217,
regarding exit statement and test logic in init.d/apache2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
359217: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=359217
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: apache-common
Version: 2.0.54-5
Severity: normal
Tags: patch

1.

In /etc/init.d on line 76 it says that the script is supposed to
exit automagically, but the code responsible goes like this (line 78):

PIDS=`pidof apache2` || true

and the return value will not be checked later so i suggest it was
intended to be:

PIDS=`pidof apache2` || exit


2.

I suggest to change the test at line 48 to check for the $PID itself
instead for checking the $PIDFILE that has allready be verified some
lines above:

if [ -n $PID ]

intead of:

if [ -e "$PIDFILE" ]

--- apache2.orig	2005-09-05 16:23:42.000000000 +0200
+++ apache2	2006-03-27 13:14:20.400228312 +0200
@@ -45,10 +45,8 @@
 	if `apache2 -t > /dev/null 2>&1`; then
 		# if the config is ok than we just stop normaly
 
-		if [ -e "$PIDFILE" ]
+		if [ -n $PID ]
 		then
-			PID=`cat $PIDFILE`
-
 			$APACHE2 -k stop
 
 			CNT=0
@@ -68,7 +66,7 @@
 				sleep 1
 			done
 		else
-			echo -n " ... no pidfile found! not running?"
+			echo -n " ... pid not found! not running?"
 		fi
 
 	else
@@ -77,7 +75,7 @@
 
 		# if pidof is null for some reasons the script exits automagically
 		# classified as good/unknown feature
-		PIDS=`pidof apache2` || true
+		PIDS=`pidof apache2` || exit
 
 		REALPID=0
 		# if there is a pid we need to verify that belongs to apache2

--- End Message ---
--- Begin Message ---
Version: 1.3.34-4.1+rm

You filed the bug http://bugs.debian.org/359217 in Debian BTS
against the package apache-common. I'm closing it at *unstable*, but it will
remain open for older distributions.

For more information about this package's removal, read
http://bugs.debian.org/418266. That bug might give the reasons why
this package was removed and suggestions of possible replacements.

Don't hesitate to reply to this mail if you have any question.

Thank you for your contribution to Debian.

--
Marco Rodrigues


--- End Message ---

Reply to: