Bug#555687: apache2: init.d pidof_apache return 1 with sh -e stops the script
Package: apache2.2-common
Version: 2.2.9-10+lenny4
Severity: normal
/etc/init.d/apache2 runs with #!/bin/sh -e
but one function pidof_apache can return 1 (failure).
In that case the whole script will stop immediately.
So, for example, if apache is not running,
/etc/init.d/apache status prints nothing.
If the return 1 is removed, it correctly prints:
Apache is not running. failed!
patch:
--- apache2.orig 2009-11-11 05:07:50.000000000 +0000
+++ /i/apache2 2009-11-11 05:07:53.000000000 +0000
@@ -84,10 +84,8 @@
# pidfile matches one of the pidof apache
# so a simple kill will make it
echo $i
- return 0
fi
done
- return 1
}
apache_stop() {
-- Package-specific info:
List of enabled modules from 'apache2 -M':
alias auth_basic authn_file authz_default authz_groupfile
authz_host authz_user autoindex cgi dir env mime negotiation php5
rewrite setenvif status
-- System Information:
Debian Release: 5.0.3
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-2-xen-amd64 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages apache2 depends on:
ii apache2-mpm-prefork 2.2.9-10+lenny4 Apache HTTP Server - traditional n
apache2 recommends no packages.
apache2 suggests no packages.
Versions of packages apache2.2-common depends on:
ii apache2-utils 2.2.9-10+lenny4 utility programs for webservers
ii libapr1 1.2.12-5+lenny1 The Apache Portable Runtime Librar
ii libaprutil1 1.2.12+dfsg-8+lenny4 The Apache Portable Runtime Utilit
ii libc6 2.7-18 GNU C Library: Shared libraries
ii libmagic1 4.26-1 File type determination library us
ii libssl0.9.8 0.9.8g-15+lenny5 SSL shared libraries
ii lsb-base 3.2-20 Linux Standard Base 3.2 init scrip
ii mime-support 3.44-1 MIME files 'mime.types' & 'mailcap
ii net-tools 1.60-22 The NET-3 networking toolkit
ii perl 5.10.0-19lenny2 Larry Wall's Practical Extraction
ii procps 1:3.2.7-11 /proc file system utilities
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
-- no debconf information
Reply to: