[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#337325: mod_proxy: encodes URLs in error messages wrongly

forwarded 337325 http://issues.apache.org/bugzilla/show_bug.cgi?id=40952
tags 337325 patch


> The URL inside the href="..." shouldn't be URL-encoded, it should be HTML
> encoded.

Yes indeed. I've forwarded this to upstream with a patch, which I'm
attaching here aswell. Thanks for reporting!

Index: modules/proxy/proxy_util.c
--- modules/proxy/proxy_util.c	(revision 473940)
+++ modules/proxy/proxy_util.c	(working copy)
@@ -497,7 +497,7 @@
     apr_table_setn(r->notes, "error-notes",
         "The proxy server could not handle the request "
-        "<em><a href=\"", ap_escape_uri(r->pool, r->uri),
+        "<em><a href=\"", ap_escape_html(r->pool, r->uri),
         "\">", ap_escape_html(r->pool, r->method),
         ap_escape_html(r->pool, r->uri), "</a></em>.<p>\n"

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: