[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#378105: apr-util: .pc and apu-config --libs list recursive deps



Package: libaprutil1-dev
Version: 1.2.7-2
Severity: minor
Tags: patch

  $ pkg-config --libs apr-util-1
  -laprutil-1 -lldap -llber -ldb-4.3 -lpq -lsqlite3 -lexpat -lapr-1

  $ apu-1-config --libs
   -lldap -llber -ldb-4.3 -lpq -lsqlite3 -lexpat

These really should not list recursive dependencies except with the
--static flag to pkg-config.

A related point is that /usr/lib/libaprutil-1.la is not needed and
should not, IMO, be shipped.  But note that deleting that would require
another trivial edit to apu-config, to make --link-libtool say the same
as --link-ld.  I did not make that change.

Peter
#! /bin/sh /usr/share/dpatch/dpatch-run
## apu-config.dpatch by <peter@p12n.org>
##
## DP: Prevent recursive linking of dependent libraries by apr-util users.

@DPATCH@
Index: apr-util.pc.in
--- a/apr-util.pc.in
+++ b/apr-util.pc.in
@@ -8,6 +8,7 @@
 Description: Companion library for APR
 Version: @APRUTIL_DOTTED_VERSION@
 # assume that apr-util requires libapr of same major version
-Requires: apr-@APRUTIL_MAJOR_VERSION@
-Libs: -L${libdir} -l@APRUTIL_LIBNAME@ @APRUTIL_EXPORT_LIBS@
+Requires.private: apr-@APRUTIL_MAJOR_VERSION@
+Libs: -L${libdir} -l@APRUTIL_LIBNAME@
+Libs.private: @APRUTIL_EXPORT_LIBS@
 Cflags: -I${includedir}
Index: apu-config.in
--- a/apu-config.in
+++ b/apu-config.in
@@ -27,7 +27,7 @@
 libdir="@libdir@"
 includedir="@includedir@"
 
-LIBS="@APRUTIL_EXPORT_LIBS@"
+LIBS=
 INCLUDES="@APRUTIL_INCLUDES@"
 LDFLAGS="@APRUTIL_LDFLAGS@"
 

Attachment: signature.asc
Description: Digital signature


Reply to: