Bug#316303: marked as done (apache2-common: apache2ctl -k stop not being used - faulty init.d/apache2 logic)
Your message dated Sat, 22 Oct 2005 18:47:11 -0700
with message-id <E1ETUx5-00060C-00@spohr.debian.org>
and subject line Bug#316303: fixed in apache2 2.0.55-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Jun 2005 23:35:05 +0000
>From jagerman@jagerman.com Wed Jun 29 16:35:05 2005
Return-path: <jagerman@jagerman.com>
Received: from myth.nmsrv.com [216.18.5.100] (qmailr)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Dnm5B-0005rB-00; Wed, 29 Jun 2005 16:35:05 -0700
Received: (qmail 22314 invoked from network); 29 Jun 2005 23:35:03 -0000
X-AntiVirus: Clean
Received: from unknown (HELO cytherea.office.gossamer-threads.com) (216.18.5.209)
by myth with SMTP; 29 Jun 2005 23:35:03 -0000
Received: from jagerman by cytherea.office.gossamer-threads.com with local (Exim 4.51)
id 1Dnlbg-0000mG-FR; Wed, 29 Jun 2005 16:04:36 -0700
Content-Type: multipart/mixed; boundary="===============0942099763=="
MIME-Version: 1.0
From: Jason Rhinelander <jagerman@jagerman.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: apache2-common: apache2ctl -k stop not being used - faulty init.d/apache2
logic
X-Mailer: reportbug 3.15
Date: Wed, 29 Jun 2005 16:04:36 -0700
Message-Id: <E1Dnlbg-0000mG-FR@cytherea.office.gossamer-threads.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============0942099763==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: apache2-common
Version: 2.0.54-4
Severity: normal
Tags: patch
The /etc/init.d/apache2 init script that comes with apache2-common has a
logic error that causes the script to always fall back to killing apache
instead of using apache2ctl -k stop.
Basically it's because this:
if `apache2 -t > /dev/null 2>&1`; then
will always be false, due to being in backticks. After fixing this, I
also noticed and added a fix for bug 290060, which is that `apache2 -k
stop' is being called inside this if statement instead of `apache2ctl -k
stop'.
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-rc4
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Versions of packages apache2-common depends on:
ii apache2-utils 2.0.54-4 utility programs for webservers
ii debconf 1.4.51 Debian configuration management sy
ii debianutils 2.14.1 Miscellaneous utilities specific t
ii libc6 2.3.5-1 GNU C Library: Shared libraries an
ii libdb4.2 4.2.52-19 Berkeley v4.2 Database Libraries [
ii libexpat1 1.95.8-3 XML parsing C library - runtime li
ii libgcc1 1:4.0.0-11 GCC support library
ii libmagic1 4.12-1 File type determination library us
ii mime-support 3.34-1 MIME files 'mime.types' & 'mailcap
ii net-tools 1.60-13 The NET-3 networking toolkit
ii openssl 0.9.7g-1 Secure Socket Layer (SSL) binary a
ii ssl-cert 1.0-11 Simple debconf wrapper for openssl
apache2-common recommends no packages.
-- no debconf information
--===============0942099763==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="apache2-init-script-logic.patch"
--- /etc/init.d/apache2 2005-06-29 14:19:11.000000000 -0700
+++ /etc/init.d/apache2.fixed 2005-06-29 14:19:08.000000000 -0700
@@ -42,14 +42,12 @@
fi
done
- if `apache2 -t > /dev/null 2>&1`; then
+ if $APACHE2 -t > /dev/null 2>&1; then
# if the config is ok than we just stop normaly
- if [ -e "$PIDFILE" ]
+ if [ -n "$PID" ]
then
- PID=`cat $PIDFILE`
-
- $APACHE2 -k stop
+ $APACHE2CTL -k stop
CNT=0
while [ 1 ]
--===============0942099763==--
---------------------------------------
Received: (at 316303-close) by bugs.debian.org; 23 Oct 2005 01:48:10 +0000
>From katie@spohr.debian.org Sat Oct 22 18:48:10 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1ETUx5-00060C-00; Sat, 22 Oct 2005 18:47:11 -0700
From: Adam Conrad <adconrad@0c3.net>
To: 316303-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#316303: fixed in apache2 2.0.55-1
Message-Id: <E1ETUx5-00060C-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sat, 22 Oct 2005 18:47:11 -0700
Delivered-To: 316303-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: apache2
Source-Version: 2.0.55-1
We believe that the bug you reported is fixed in the latest version of
apache2, which is due to be installed in the Debian FTP archive:
apache2-common_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-common_2.0.55-1_i386.deb
apache2-doc_2.0.55-1_all.deb
to pool/main/a/apache2/apache2-doc_2.0.55-1_all.deb
apache2-mpm-perchild_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-mpm-perchild_2.0.55-1_i386.deb
apache2-mpm-prefork_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-mpm-prefork_2.0.55-1_i386.deb
apache2-mpm-worker_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-mpm-worker_2.0.55-1_i386.deb
apache2-prefork-dev_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-prefork-dev_2.0.55-1_i386.deb
apache2-threaded-dev_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-threaded-dev_2.0.55-1_i386.deb
apache2-utils_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2-utils_2.0.55-1_i386.deb
apache2_2.0.55-1.diff.gz
to pool/main/a/apache2/apache2_2.0.55-1.diff.gz
apache2_2.0.55-1.dsc
to pool/main/a/apache2/apache2_2.0.55-1.dsc
apache2_2.0.55-1_i386.deb
to pool/main/a/apache2/apache2_2.0.55-1_i386.deb
apache2_2.0.55.orig.tar.gz
to pool/main/a/apache2/apache2_2.0.55.orig.tar.gz
libapr0-dev_2.0.55-1_i386.deb
to pool/main/a/apache2/libapr0-dev_2.0.55-1_i386.deb
libapr0_2.0.55-1_i386.deb
to pool/main/a/apache2/libapr0_2.0.55-1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 316303@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Conrad <adconrad@0c3.net> (supplier of updated apache2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 17 Oct 2005 13:00:13 +1000
Source: apache2
Binary: apache2-utils apache2 apache2-prefork-dev apache2-mpm-prefork apache2-doc libapr0-dev apache2-mpm-worker libapr0 apache2-threaded-dev apache2-common apache2-mpm-perchild
Architecture: source i386 all
Version: 2.0.55-1
Distribution: unstable
Urgency: low
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Adam Conrad <adconrad@0c3.net>
Description:
apache2 - next generation, scalable, extendable web server
apache2-common - next generation, scalable, extendable web server
apache2-doc - documentation for apache2
apache2-mpm-perchild - experimental high speed perchild threaded model for Apache2
apache2-mpm-prefork - traditional model for Apache2
apache2-mpm-worker - high speed threaded model for Apache2
apache2-prefork-dev - development headers for apache2
apache2-threaded-dev - development headers for apache2
apache2-utils - utility programs for webservers
libapr0 - the Apache Portable Runtime
libapr0-dev - development headers for libapr
Closes: 303076 316303 327269 331741 332791 333363
Changes:
apache2 (2.0.55-1) unstable; urgency=low
.
* New upstream bugfix and security release, superseding these patches:
- Drop 041_util_ldap_fix.patch, util_ldap seems to be unbroken.
- Drop 043_ssl_off_by_one_CAN-2005-1268, fixed upstream.
- Drop 044_content_length_CAN-2005-2088, fixed upstream.
- Drop 045_byterange_CAN-2005-2728, fixed upstream.
- Drop 046_verify_client_CAN-2005-2700, fixed upstream.
- Add 048_reverse_proxy_fix, to resolve a regression in 2.0.55 with
mod_proxy, mod_ssl and HTTP POST requests (upstream bug #37145)
* New release builds cleanly with OpenSSL 0.9.8 (closes: #332791, #333363)
* Fix up our built-in version of DBS to use find's -{max,min}depth
arguments in a way that doesn't make find whine like a spoiled child.
* Merge Ubuntu and Debian packaging, bringing in patch 047 (closes: #327269)
- Comment out the / -> /apache2-default/ redirect, as user feedback seems
to indicate that it's just too bloody confusing for most people.
- New installations (only) now get an AddDefaultCharset UTF-8 directive.
* Build-depend on lsb-release, and use it in debian/rules to determine which
distribution we're building on, dropping the 007_debian_advertising patch.
* Drop debconf dependency entirely; we don't even use it (closes: #331741)
* Finally support DEB_BUILD_OPTIONS="noopt debug" properly in debian/rules.
* Adjust mime_magic.conf to point at the new FHS location of magic.mime.
* Drop the apache2-mpm-threadpool transitional package; Sarge is released.
* Try a bit harder to find the *CORRECT* PidFile directive in the init
script, instead of the old "rgrep and pray" method (closes: #303076)
* Make init script to always use apache2ctl consistently (closes: #316303)
* Build (and have -dev packages depend on) libdb4.3 instead of libdb4.2.
Files:
dfd3a5df3d9065daf362b1985aca1c62 1130 net optional apache2_2.0.55-1.dsc
45e32c9432a8e3cf4227f5af91b03622 6092031 net optional apache2_2.0.55.orig.tar.gz
9508f1cda90ebf1bf7b57702a7194585 112357 net optional apache2_2.0.55-1.diff.gz
13b5fa62553998814b07e9097724a85c 2122848 doc optional apache2-doc_2.0.55-1_all.deb
d23c5a40d5e06b1424d557cc846c758c 788176 net optional apache2-common_2.0.55-1_i386.deb
27de0a1560fb9834ed8b3d811ae6df70 90690 net optional apache2-utils_2.0.55-1_i386.deb
f9a2b5228973a8071875c9ef3ec21100 204412 net optional apache2-mpm-worker_2.0.55-1_i386.deb
614f3945feaecf632ab3efc50558b172 204736 net optional apache2-mpm-perchild_2.0.55-1_i386.deb
576abfe89f655c2b8ce861dc1b01ab6f 200826 net optional apache2-mpm-prefork_2.0.55-1_i386.deb
b52a8cf62585527369966d6945476318 169524 devel optional apache2-prefork-dev_2.0.55-1_i386.deb
f9dda52b36249f73d07bfaf3c1dc8056 170296 devel optional apache2-threaded-dev_2.0.55-1_i386.deb
4e6da20013774c583dcbe2e47402c09b 131236 net optional libapr0_2.0.55-1_i386.deb
38168867bbc6d8732d9deed23699f1dd 262892 libdevel optional libapr0-dev_2.0.55-1_i386.deb
3da2360680d72ec26ba95446b89818e3 34372 web optional apache2_2.0.55-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDWuSuvjztR8bOoMkRAlrgAJ4gdUgvwf7wlCYvEBeInon2SvDE+QCgksCw
0CagupgQGNdZ/2Q1db+kATE=
=fjvX
-----END PGP SIGNATURE-----
Reply to: