[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#280549: marked as done (listconffiles should ignore files like apache does)



Your message dated Wed, 10 Nov 2004 06:41:40 +0100
with message-id <20041110054140.GA28649@opium.multi24.com>
and subject line Bug#280549: Acknowledgement (listconffiles should ignore files like apache does)
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 10 Nov 2004 05:28:00 +0000
>From weasel@debian.org Tue Nov 09 21:28:00 2004
Return-path: <weasel@debian.org>
Received: from opium.multi24.com [213.239.202.166] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CRl1U-0002Py-00; Tue, 09 Nov 2004 21:28:00 -0800
Received: by opium.multi24.com (Postfix, from userid 1000)
	id AD4A5400096; Wed, 10 Nov 2004 06:27:58 +0100 (CET)
Date: Wed, 10 Nov 2004 06:27:58 +0100
From: Peter Palfrader <weasel@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: listconffiles should ignore files like apache does
Message-ID: <[🔎] 20041110052758.GA5944@opium.multi24.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
X-Reportbug-Version: 2.63
X-PGP: 1024D/94C09C7F 5B00 C96D 5D54 AEE1 206B  AF84 DE7A AF6E 94C0 9C7F
X-Request-PGP: http://www.palfrader.org/keys/94C09C7F.asc
X-Accept-Language: de, en
User-Agent: Mutt/1.5.6+20040722i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: apache
Version: 1.3.31-7
Severity: normal
Tags: patch

Hi Fabbione,

we talked about this in September.

| Setting up apache (1.3.31-7) ...
| Use of uninitialized value in pattern match (m//) at
|         /usr/share/apache/listconffiles line 92, <> line 495 (#1)
|     (W uninitialized) An undefined value was used as if it were already
|     defined.  It was interpreted as a "" or a 0, but maybe it was a mistake.
|     To suppress this warning assign a defined value to your variables.
| 
|     To help you figure out what was undefined, perl tells you what operation
|     you used the undefined value in.  Note, however, that perl optimizes your
|     program and the operation displayed in the warning may not necessarily
|     appear literally in your program.  For example, "that $foo" is
|     usually optimized into "that " . $foo, and the warning will refer to
|     the concatenation (.) operator, even though there is no . in your
|     program.
| 
| Use of uninitialized value in pattern match (m//) at
|         /usr/share/apache/listconffiles line 97, <> line 495 (#1)
| Use of uninitialized value in pattern match (m//) at
|         /usr/share/apache/listconffiles line 108, <> line 495 (#1)


In etc/apache/conf.d I have RCS files, and apache (with the debian)
patch ignores those filers properly (they have a , in their name).
Unfortunately listconffiles doesn't have the same behaviour.

That is the patch I sent you in September:

--- /usr/share/apache/listconffiles	2004-06-11 00:10:07.000000000 +0200
+++ listconffiles	2004-09-20 14:11:06.000000000 +0200
@@ -27,12 +27,20 @@
 # must be the base config file.
 #
 
+sub usage() {
+	print STDERR "Usage: $0 [-V] <baseconfigfile>\n";
+	exit 1;
+}
+
+usage() unless scalar @ARGV > 0;
+
 if ( $ARGV[0] eq "-V" ) {
   $withvhosts = 1;
-  $baseconfig=$ARGV[1];
-} else {
-  $baseconfig=$ARGV[0];
-}
+  shift @ARGV;
+};
+usage() unless scalar @ARGV == 1;
+$baseconfig = shift @ARGV;
+
 
 scanfile($baseconfig);
 
@@ -130,7 +138,8 @@
 #  $dir =~ s/\"//g;
 #  print "DEBUG: working on $dir with regexp $glob\n";
   opendir (DIR, $dir) or warn "Can't open directory $dir\n$!\n";
-  my @files = grep (!/^\.{1,2}$/ && /^$glob$/, readdir(DIR));
+  # ignore ., .., and RCS style ,v files.  And glob
+  my @files = grep (!/^\.{1,2}$/ && !/,v$/ && /^$glob$/, readdir(DIR));
 #  print "DEBUG: found @files\n";
   closedir DIR;
   foreach (@files) {


-- 
Peter

---------------------------------------
Received: (at 280549-done) by bugs.debian.org; 10 Nov 2004 05:41:42 +0000
>From weasel@debian.org Tue Nov 09 21:41:42 2004
Return-path: <weasel@debian.org>
Received: from opium.multi24.com [213.239.202.166] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CRlEk-0006u1-00; Tue, 09 Nov 2004 21:41:42 -0800
Received: by opium.multi24.com (Postfix, from userid 1000)
	id 04B4E400096; Wed, 10 Nov 2004 06:41:41 +0100 (CET)
Date: Wed, 10 Nov 2004 06:41:40 +0100
From: Peter Palfrader <weasel@debian.org>
To: 280549-done@bugs.debian.org
Subject: Re: Bug#280549: Acknowledgement (listconffiles should ignore files like apache does)
Message-ID: <20041110054140.GA28649@opium.multi24.com>
References: <[🔎] 20041110052758.GA5944@opium.multi24.com> <handler.280549.B.11000644809311.ack@bugs.debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <handler.280549.B.11000644809311.ack@bugs.debian.org>
X-PGP: 1024D/94C09C7F 5B00 C96D 5D54 AEE1 206B  AF84 DE7A AF6E 94C0 9C7F
X-Request-PGP: http://www.palfrader.org/keys/94C09C7F.asc
X-Accept-Language: de, en
User-Agent: Mutt/1.5.6+20040722i
Delivered-To: 280549-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

On Tue, 09 Nov 2004, Debian Bug Tracking System wrote:

> Thank you for the problem report you have sent regarding Debian.

According to fabbione the issue has been fixed in sid 3 days ago.
Thanks.

-- 
 PGP signed and encrypted  |  .''`.  ** Debian GNU/Linux **
    messages preferred.    | : :' :      The  universal
                           | `. `'      Operating System
 http://www.palfrader.org/ |   `-    http://www.debian.org/



Reply to: