[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#236882: apache-perl: The patch from bug 226131 is the culprit!

tags 236882 + pending

Ok I am temporary reverting the patch even if it is already upstream for
the next release of mod_perl. The submitter of 226131 is in CC but i
didn't receive any information from him yet.


On Mon, 8 Mar 2004, Dave Rolsky wrote:

> Package: apache-perl
> Version:
> Severity: normal
> Followup-For: Bug #236882
> I rebuilt the apache packages from the Debian source without the patch
> provided in bug report 226131, and it starts up fine.
> Looking at the code being patched, I have absolutely no idea why it
> would cause a segfault with the patch applied.  However, I think the
> patch may just be incorrect.  It's testing if if RETVAL is "SvOK", but
> _all_ SVs are SvOK, whether they are the Nullsv global, or a new SV
> created via newSV!
> The point of calling SvOK is to test if the variable in question is an
> SV* at all, not to test its value.
> The code is basically broken, because it needs to check to see if it
> the per-dir-config table contains the given key.  If not, it should
> look at the server's table, I believe.
> Frankly, I think the original bug (re: dir_config) is _far_ less
> severe than a segfault, and should be backed out.
> -- System Information:
> Debian Release: testing/unstable
>   APT prefers unstable
>   APT policy: (500, 'unstable')
> Architecture: i386 (i686)
> Kernel: Linux 2.4.24
> Locale: LANG=C, LC_CTYPE=C
> Versions of packages apache-perl depends on:
> ii  apache-common      Support files for all Apache webse
> ii  debconf                     1.4.13       Debian configuration management sy
> ii  dpkg                  Package maintenance system for Deb
> ii  libapache-mod-perl   Integration of perl with the Apach
> ii  libc6                       2.3.2.ds1-11 GNU C Library: Shared libraries an
> ii  libdb4.2                    4.2.52-12    Berkeley v4.2 Database Libraries [
> ii  libexpat1                   1.95.6-8     XML parsing C library - runtime li
> ii  libmagic1                   4.07-2       File type determination library us
> ii  libpam0g                    0.76-15      Pluggable Authentication Modules l
> ii  libperl5.8                  5.8.3-2      Shared Perl library.
> ii  mime-support                3.26-1       MIME files 'mime.types' & 'mailcap
> -- debconf information:
>   apache-perl/old-pidfile-set:
> * apache-perl/server-port: 80
> * apache-perl/init: true
> * apache-perl/enable-suexec: false
> * apache-perl/document-root: "/var/www"
> * apache-perl/upgrade-from-apache-conflict:
> * apache-perl/server-name: localhost
> * apache-perl/server-admin: autarch@houseabsolute.urth.org

<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.

Reply to: