[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#226131: marked as done ($r->dir_config('foo') returns undef instead of 0 when PerlSetVar foo '0')



Your message dated Sun, 07 Mar 2004 08:32:06 -0500
with message-id <E1AzyNy-0001r9-00@newraff.debian.org>
and subject line Bug#226131: fixed in apache 1.3.29.0.2-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 4 Jan 2004 17:48:11 +0000
>From don@donarmstrong.com Sun Jan 04 11:48:11 2004
Return-path: <don@donarmstrong.com>
Received: from mxsf27.cluster1.charter.net [209.225.28.227] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AcyCX-00006T-00; Sat, 03 Jan 2004 20:41:13 -0600
Received: from donarmstrong.com (66-215-230-252.riv-eres.charterpipeline.net [66.215.230.252])
	by mxsf27.cluster1.charter.net (8.12.10/8.12.8) with SMTP id i042eALT072776
	for <submit@bugs.debian.org>; Sat, 3 Jan 2004 21:40:10 -0500 (EST)
	(envelope-from don@donarmstrong.com)
Received: (nullmailer pid 5249 invoked by uid 1000);
	Sun, 04 Jan 2004 02:40:08 -0000
Date: Sat, 3 Jan 2004 18:40:08 -0800
From: Don Armstrong <don@donarmstrong.com>
To: submit@bugs.debian.org
Subject: $r->dir_config('foo') returns undef instead of 0 when PerlSetVar foo '0'
Message-ID: <20040104024008.GM24175@donarmstrong.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Ll0BBk1HBk/f94B0"
Content-Disposition: inline
X-Face: &M"4U@"QPr*4J='o3uX!C)l^-k6eODr4^>[lX^"g,Ac,>H~+.>_A4bk/GikjcXy?kOy-OitMH)J^MzgI",O5FjF,BxntA-<ERisZX:@dEb%7K+;hya%WR,6a:%h{HBv1Y<Y5=[Zz>z^KXVP9#enwq2X[^'f9tynS2@L0+'sQ"eh+LxX4R}"Xzd6BNr8.@Wu{jyNx|]tJG.*H^IDrsA%3
User-Agent: Mutt/1.5.4i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 
	2.60-master.debian.org_2003_11_25-bugs.debian.org_2004_1_3 
	(1.212-2003-09-23-exp) on master.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 
	version=2.60-master.debian.org_2003_11_25-bugs.debian.org_2004_1_3
X-Spam-Level: 


--Ll0BBk1HBk/f94B0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: libapache-mod-perl
Version: 1.29.0.1-3
Severity: important
Tags: patch

An apache configuration with:

<Location />
     PerlSetVar foo '0';
</Location>

Causes $r->dir_config('foo') to return undef unstead of zero. However,
$r->dir_config returns a hashref with the appropriate values set.

Apparently, the following patch[1] fixes this issue, but I have not yet
tried it myself. (It looks reasonable though...)

Index: src/modules/perl/Apache.xs
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/cvspublic/modperl/src/modules/perl/Apache.xs,v
retrieving revision 1.129
diff -u -r1.129 Apache.xs
--- src/modules/perl/Apache.xs 16 Sep 2003 19:51:06 -0000 1.129
+++ src/modules/perl/Apache.xs 25 Nov 2003 20:39:41 -0000
@@ -2084,7 +2084,7 @@
&perl_module);
TABLE_GET_SET(c->vars, FALSE);
}
- if (!SvTRUE(RETVAL)) {
+ if (!SvOK(RETVAL)) {
s =3D r && r->server ? r->server : perl_get_startup_server();
if (s && s->module_config) {
SvREFCNT_dec(RETVAL); /* in case above did newSV(0) */


Don Armstrong

1: http://www.gossamer-threads.com/archive/mod_perl_C1/modperl_F7/PerlSetVa=
r_with_0_value_P90608/
--=20
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead
bodies. Do you think I want to have an academic debate on this
subject?"
 -- Robert Fisk

http://www.donarmstrong.com
http://www.anylevel.com
http://rzlab.ucr.edu

--Ll0BBk1HBk/f94B0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/930IgcCJIoCND9ARAiVpAKCIh8BVVo79+wC+AxjCt82+Ga7mvgCgh8Dn
Ne3keSaN3/QGNDsZD46kqF0=
=tUnv
-----END PGP SIGNATURE-----

--Ll0BBk1HBk/f94B0--

---------------------------------------
Received: (at 226131-close) by bugs.debian.org; 7 Mar 2004 13:38:08 +0000
>From katie@ftp-master.debian.org Sun Mar 07 05:38:08 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AzyTo-0001wX-00; Sun, 07 Mar 2004 05:38:08 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1AzyNy-0001r9-00; Sun, 07 Mar 2004 08:32:06 -0500
From: fabbione@fabbione.net (Fabio M. Di Nitto)
To: 226131-close@bugs.debian.org
X-Katie: $Revision: 1.44 $
Subject: Bug#226131: fixed in apache 1.3.29.0.2-1
Message-Id: <E1AzyNy-0001r9-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 07 Mar 2004 08:32:06 -0500
Delivered-To: 226131-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_05 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=no 
	version=2.60-bugs.debian.org_2004_03_05
X-Spam-Level: 

Source: apache
Source-Version: 1.3.29.0.2-1

We believe that the bug you reported is fixed in the latest version of
apache, which is due to be installed in the Debian FTP archive:

apache-common_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-common_1.3.29.0.2-1_i386.deb
apache-dbg_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-dbg_1.3.29.0.2-1_i386.deb
apache-dev_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-dev_1.3.29.0.2-1_i386.deb
apache-doc_1.3.29.0.2-1_all.deb
  to pool/main/a/apache/apache-doc_1.3.29.0.2-1_all.deb
apache-perl_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-perl_1.3.29.0.2-1_i386.deb
apache-ssl_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-ssl_1.3.29.0.2-1_i386.deb
apache-utils_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache-utils_1.3.29.0.2-1_i386.deb
apache_1.3.29.0.2-1.diff.gz
  to pool/main/a/apache/apache_1.3.29.0.2-1.diff.gz
apache_1.3.29.0.2-1.dsc
  to pool/main/a/apache/apache_1.3.29.0.2-1.dsc
apache_1.3.29.0.2-1_i386.deb
  to pool/main/a/apache/apache_1.3.29.0.2-1_i386.deb
apache_1.3.29.0.2.orig.tar.gz
  to pool/main/a/apache/apache_1.3.29.0.2.orig.tar.gz
libapache-mod-perl_1.29.0.2-1_i386.deb
  to pool/main/a/apache/libapache-mod-perl_1.29.0.2-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 226131@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Fabio M. Di Nitto <fabbione@fabbione.net> (supplier of updated apache package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 07 Mar 2004 13:15:09 +0100
Source: apache
Binary: apache-dev apache-common apache-doc apache-utils apache apache-dbg apache-perl libapache-mod-perl apache-ssl
Architecture: source i386 all
Version: 1.3.29.0.2-1
Distribution: unstable
Urgency: low
Maintainer: Debian Apache Maintainers <debian-apache@lists.debian.org>
Changed-By: Fabio M. Di Nitto <fabbione@fabbione.net>
Description: 
 apache     - Versatile, high-performance HTTP server
 apache-common - Support files for all Apache webservers
 apache-dbg - Apache webservers (debugging versions)
 apache-dev - Apache webserver development kit
 apache-doc - Apache webserver docs
 apache-perl - Versatile, high-performance HTTP server with Perl support
 apache-ssl - Versatile, high-performance HTTP server with SSL support
 apache-utils - Utility programs for webservers
 libapache-mod-perl - Integration of perl with the Apache web server
Closes: 45268 219378 226131 226833 227232 228355 229000 229653 230718 230991 231387 232630 232668 233097 233694 234091 234650 234706 234731 235976
Changes: 
 apache (1.3.29.0.2-1) unstable; urgency=low
 .
   * (Fabio M. Di Nitto)
     - Introduced better checks for values returned by debconf frontens
       and rollback to defaults if empty (Closes: #234091)
     - Introduced ucf to preserve users configurations across upgrades
       (Closes: #227232, #235976, #234650)
     - Fixed several overlapping problems with postrm scripts
       (Closes: #232668)
     - New apache-ssl upstream [CAN-2004-0009]
       (Closes: #232630)
     - Make modules-config less paranoid about .so/.info relationship
       (Closes: #226833, #234706)
     - Updated default apache-ssl conf for new SSLNoV2 directive
     - Rebuilt and enforced dependencies against perl 5.8.3
       (Closes: #231387)
     - Switched logrotate scripts to use invoke-rc.d and Co.
       (Closes: #234731)
     - Added (for real this time) mod-perl r->dir_config('foo') patch. Thanks Don.
       (Closes: #226131)
     - Modified init scripts and postinst to handle in a better way the start
       at boot. (Closes: #228355)
     - Added link to netcraft.com in the default placeholder and a few lines
       in the README.Debian
     - Modified init scripts to clean mod-bandwidth/link/ after each stop
       (Closes: #229000)
     - More init scripts cleanup. It shouldn't leak environment information
       (Closes: #229653, #230991)
     - Added check for MIMEMagicFile to suggested corrections
       (Closes: #230718)
     - Added da.po thanks to Claus Hindsgaul (Closes: #233097)
   * (Tollef Fog Heen)
     - Stop linking against so many DB libs. (Closes: #45268)
   * (Matthew Wilcox)
     - Ship rotatelogs in apache-utils. (Closes: #219378)
     - Add mod_autoindex patch. (Closes: #233694)
Files: 
 2c2f436049a261d425f7a33ade8e1c32 1085 web optional apache_1.3.29.0.2-1.dsc
 cc7d80570bfce92a4743c297a1fd1004 3071092 web optional apache_1.3.29.0.2.orig.tar.gz
 685c35aae699c0e19958736a9c3bce60 374701 web optional apache_1.3.29.0.2-1.diff.gz
 cf14ac454403e89dfcde8d6dd2b535cc 1158450 doc optional apache-doc_1.3.29.0.2-1_all.deb
 183c94fecba25014692654e26bf04e59 367170 web optional apache_1.3.29.0.2-1_i386.deb
 989ca889e96e620696653bbce2a360fb 478130 web optional apache-ssl_1.3.29.0.2-1_i386.deb
 74e6a958e9609ca633182e99b50ddbe7 485688 web extra apache-perl_1.3.29.0.2-1_i386.deb
 b3620575930b34b63667c0f958f880e9 316708 devel extra apache-dev_1.3.29.0.2-1_i386.deb
 3987b0ca06198160e430b1bef96895e1 9074574 devel extra apache-dbg_1.3.29.0.2-1_i386.deb
 fe4db14d1ec9434af7f92a819f5cd19d 816424 web optional apache-common_1.3.29.0.2-1_i386.deb
 29bf856f65bb50e18d5d6151a852088c 257794 web optional apache-utils_1.3.29.0.2-1_i386.deb
 6a272db812c36314cee3cdb14fd8a4b0 480216 web optional libapache-mod-perl_1.29.0.2-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFASx1jhCzbekR3nhgRAj3CAJ9JciF73J6YNddTi6id3AdXrSZTSgCfbiGb
e2LQB+i3aBND88PPrwWwcaY=
=N3tl
-----END PGP SIGNATURE-----



Reply to: